Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Bart Van Assche
On 2020-05-30 09:41, James Bottomley wrote: > On Sat, 2020-05-30 at 09:24 -0700, Bart Van Assche wrote: >> On 2020-05-30 02:32, Simon Arlott wrote: >>> If the device minor cannot be allocated or the cdrom fails to be >>> registered then the mutex should be destroyed. >> >> Please add Fixes: and

Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread James Bottomley
On Sat, 2020-05-30 at 09:24 -0700, Bart Van Assche wrote: > On 2020-05-30 02:32, Simon Arlott wrote: > > If the device minor cannot be allocated or the cdrom fails to be > > registered then the mutex should be destroyed. > > Please add Fixes: and Cc: stable tags. This isn't really a bug, is it?

Re: [PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Bart Van Assche
On 2020-05-30 02:32, Simon Arlott wrote: > If the device minor cannot be allocated or the cdrom fails to be > registered then the mutex should be destroyed. Please add Fixes: and Cc: stable tags. Thanks, Bart.

[PATCH 1/2] scsi: sr: Fix sr_probe() missing mutex_destroy

2020-05-30 Thread Simon Arlott
If the device minor cannot be allocated or the cdrom fails to be registered then the mutex should be destroyed. Signed-off-by: Simon Arlott --- drivers/scsi/sr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index d2fe3fa470f9..8d062d4f3ce0 100644 ---