RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-05 Thread Avri Altman
> > On 5/10/20 12:51 pm, Avri Altman wrote: > >> > >> > >> On 5/10/20 11:02 am, Avri Altman wrote: > >>> HI, > >>> > Drivers that wish to support DeepSleep need to set a new capability flag > UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing > ->device_reset() call

Re: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-05 Thread Adrian Hunter
On 5/10/20 12:51 pm, Avri Altman wrote: >> >> >> On 5/10/20 11:02 am, Avri Altman wrote: >>> HI, >>> Drivers that wish to support DeepSleep need to set a new capability flag UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing ->device_reset() callback. >>> I would exp

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-05 Thread Avri Altman
> > > On 5/10/20 11:02 am, Avri Altman wrote: > > HI, > > > >> Drivers that wish to support DeepSleep need to set a new capability flag > >> UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing > >> ->device_reset() callback. > > I would expect that this capability controls sending

Re: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-05 Thread Adrian Hunter
On 5/10/20 11:02 am, Avri Altman wrote: > HI, > >> Drivers that wish to support DeepSleep need to set a new capability flag >> UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing >> ->device_reset() callback. > I would expect that this capability controls sending SSU 4, but it only

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-05 Thread Avri Altman
HI, > Drivers that wish to support DeepSleep need to set a new capability flag > UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing > ->device_reset() callback. I would expect that this capability controls sending SSU 4, but it only controls the sysfs entry? > > It is assumed t

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-04 Thread Avri Altman
vger.kernel.org; Alim Akhtar > > Subject: RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature > > > + /* > > +* DeepSleep requires the Immediate flag. DeepSleep state is > > actually > > +* entered when the link state goes to Hibern8. >

RE: [PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-04 Thread Avri Altman
> + /* > +* DeepSleep requires the Immediate flag. DeepSleep state is actually > +* entered when the link state goes to Hibern8. > +*/ > + if (pwr_mode == UFS_DEEPSLEEP_PWR_MODE) > + cmd[1] = 1; Shouldn't it be bit1, i.e. cmd[1] = 2 ? > cmd

[PATCH 1/2] scsi: ufs: Add DeepSleep feature

2020-10-02 Thread Adrian Hunter
DeepSleep is a UFS v3.1 feature that achieves the lowest power consumption of the device, apart from power off. In DeepSleep mode, no commands are accepted, and the only way to exit is using a hardware reset or power cycle. This patch assumes that if a power cycle was an option, then power off wo