Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-26 Thread Naresh Kamboju
> > Well, what about using "comm" as proposed by Michael in the other > > mail? It seems to be part of coreutils and should be everywhere. > > > > I guess that many people, including me, are not fluent in awk. > > So, I am slightly in favor of the "comm" approach ;-) > > > > comm is definitely simp

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-26 Thread Naresh Kamboju
On Thu, 25 Jun 2020 at 11:46, Kees Cook wrote: > > On Mon, Jun 22, 2020 at 02:21:38PM +0530, Naresh Kamboju wrote: > > On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > > # Record and dump the results > > > -dmesg -c >"$LOG" > > > +dmesg | diff --changed-group-format='%>' --unchanged-grou

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-26 Thread Joe Lawrence
On 6/26/20 4:02 AM, Petr Mladek wrote: On Wed 2020-06-24 16:12:47, Joe Lawrence wrote: On Wed, Jun 24, 2020 at 10:39:55AM +0200, Petr Mladek wrote: On Tue 2020-06-23 23:48:36, Joe Lawrence wrote: On 6/22/20 4:51 AM, Naresh Kamboju wrote: On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote:

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-26 Thread Petr Mladek
On Wed 2020-06-24 16:12:47, Joe Lawrence wrote: > On Wed, Jun 24, 2020 at 10:39:55AM +0200, Petr Mladek wrote: > > On Tue 2020-06-23 23:48:36, Joe Lawrence wrote: > > > On 6/22/20 4:51 AM, Naresh Kamboju wrote: > > > > On Fri, 8 May 2020 at 12:23, Michael Ellerman > > > > wrote: > > > > > > > >

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-24 Thread Kees Cook
On Mon, Jun 22, 2020 at 02:21:38PM +0530, Naresh Kamboju wrote: > On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > # Record and dump the results > > -dmesg -c >"$LOG" > > +dmesg | diff --changed-group-format='%>' --unchanged-group-format='' > > "$DMESG" - > "$LOG" || true > > We are fac

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-24 Thread Joe Lawrence
On Wed, Jun 24, 2020 at 10:39:55AM +0200, Petr Mladek wrote: > On Tue 2020-06-23 23:48:36, Joe Lawrence wrote: > > On 6/22/20 4:51 AM, Naresh Kamboju wrote: > > > On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > > > > > > > It is Very Rude to clear dmesg in test scripts. That's because th

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-24 Thread Petr Mladek
On Tue 2020-06-23 23:48:36, Joe Lawrence wrote: > On 6/22/20 4:51 AM, Naresh Kamboju wrote: > > On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > > > > > It is Very Rude to clear dmesg in test scripts. That's because the > > > script may be part of a larger test run, and clearing dmesg > >

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-23 Thread Joe Lawrence
On 6/22/20 4:51 AM, Naresh Kamboju wrote: On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: It is Very Rude to clear dmesg in test scripts. That's because the script may be part of a larger test run, and clearing dmesg potentially destroys the output of other tests. We can avoid using dmes

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-22 Thread Naresh Kamboju
On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: > > It is Very Rude to clear dmesg in test scripts. That's because the > script may be part of a larger test run, and clearing dmesg > potentially destroys the output of other tests. > > We can avoid using dmesg -c by saving the content of dmesg

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 04:53:55PM +1000, Michael Ellerman wrote: > It is Very Rude to clear dmesg in test scripts. That's because the > script may be part of a larger test run, and clearing dmesg > potentially destroys the output of other tests. > > We can avoid using dmesg -c by saving the conte

[PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-05-07 Thread Michael Ellerman
It is Very Rude to clear dmesg in test scripts. That's because the script may be part of a larger test run, and clearing dmesg potentially destroys the output of other tests. We can avoid using dmesg -c by saving the content of dmesg before the test, and then using diff to compare that to the dmes