Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

Andy Shevchenko writes: > On Mon, Apr 29, 2019 at 11:29:05AM +0200, Esben Haabendal wrote: >> Andy Shevchenko writes: >> > On Mon, Apr 29, 2019 at 9:27 AM Esben Haabendal wrote: >> >> Andy Shevchenko writes: >> >> > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal >> >> > wrote: >> >> >> Andy

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On Mon, Apr 29, 2019 at 11:29:05AM +0200, Esben Haabendal wrote: > Andy Shevchenko writes: > > On Mon, Apr 29, 2019 at 9:27 AM Esben Haabendal wrote: > >> Andy Shevchenko writes: > >> > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal > >> > wrote: > >> >> Andy Shevchenko writes: > >> >> > On

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On 29.04.19 11:29, Esben Haabendal wrote: > So maybe we should go down that direction intead, extending 8250 driver > to replace mapbase with a resource struct instead? Yeah, I already was up to do that. But that would be a pretty massive change, as the actual use of fields like mapsize/mapbase i

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

Andy Shevchenko writes: > On Mon, Apr 29, 2019 at 9:27 AM Esben Haabendal wrote: >> Andy Shevchenko writes: >> > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal >> > wrote: >> >> Andy Shevchenko writes: >> >> > On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: >> >> >> Andy S

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On Mon, Apr 29, 2019 at 9:27 AM Esben Haabendal wrote: > Andy Shevchenko writes: > > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal wrote: > >> Andy Shevchenko writes: > >> > On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: > >> >> Andy Shevchenko writes: > >> >> The reason f

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

"Enrico Weigelt, metux IT consult" writes: > On 27.04.19 10:58, Esben Haabendal wrote: > > Hi folks, > >> That said, the purpose of UPF_BOOT_AUTOCONF (for 8250 driver) is to >> request and map the register memory. So when that is already done by >> the parent MFD driver, I think it is silly to w

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

Andy Shevchenko writes: > On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal wrote: >> Andy Shevchenko writes: >> > On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: >> >> Andy Shevchenko writes: >> >> The reason for this patch is to be able to do exactly that (set port >> >> type

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On Sat, Apr 27, 2019 at 12:01 PM Esben Haabendal wrote: > Andy Shevchenko writes: > > On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: > >> Andy Shevchenko writes: > >> The reason for this patch is to be able to do exactly that (set port > >> type and UPF_FIXED_TYPE) without havi

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On 27.04.19 10:58, Esben Haabendal wrote: Hi folks, > That said, the purpose of UPF_BOOT_AUTOCONF (for 8250 driver) is to> request > and map the register memory. So when that is already done by> the parent MFD driver, I think it is silly to workaround problems caused> by UPF_BOOT_AUTOCONF being

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

Andy Shevchenko writes: > On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: >> Andy Shevchenko writes: >> > On Fri, Apr 26, 2019 at 10:40:37AM +0200, Esben Haabendal wrote: >> >> With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it >> >> is not possible to reg

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On Fri, Apr 26, 2019 at 06:54:05PM +0200, Esben Haabendal wrote: > Andy Shevchenko writes: > > On Fri, Apr 26, 2019 at 10:40:37AM +0200, Esben Haabendal wrote: > >> With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it > >> is not possible to register a port without having > >>

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

Andy Shevchenko writes: > On Fri, Apr 26, 2019 at 10:40:37AM +0200, Esben Haabendal wrote: >> With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it >> is not possible to register a port without having >> serial8250_request_std_resource() called. >> >> For adding a 8250 port t

Re: [PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

On Fri, Apr 26, 2019 at 10:40:37AM +0200, Esben Haabendal wrote: > With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it > is not possible to register a port without having > serial8250_request_std_resource() called. > > For adding a 8250 port to an MFD device, this is problema

[PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it is not possible to register a port without having serial8250_request_std_resource() called. For adding a 8250 port to an MFD device, this is problematic, as the request_mem_region() call will fail, as the MFD device (and rig

[PATCH 1/2] serial: 8250: Allow port registration without UPF_BOOT_AUTOCONF

With serial8250_register_8250_port() forcing UPF_BOOT_AUTOCONF bit on, it is not possible to register a port without having serial8250_request_std_resource() called. For adding a 8250 port to an MFD device, this is problematic, as the request_mem_region() call will fail, as the MFD device (and rig