Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-05 Thread Michal Hocko
On Sat 04-11-17 17:28:05, Hugh Dickins wrote: > On Fri, 3 Nov 2017, Michal Hocko wrote: > > On Fri 03-11-17 00:46:18, Hugh Dickins wrote: > > > > > > NAK. shmem_wait_for_pins() is waiting for temporary pins on the pages > > > to go away, and using lru_add_drain_all() in the usual way, to lower >

Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-04 Thread Hugh Dickins
On Fri, 3 Nov 2017, Michal Hocko wrote: > On Fri 03-11-17 00:46:18, Hugh Dickins wrote: > > > > NAK. shmem_wait_for_pins() is waiting for temporary pins on the pages > > to go away, and using lru_add_drain_all() in the usual way, to lower > > the refcount of pages temporarily pinned in a pagevec

Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-03 Thread David Herrmann
Hi On Fri, Nov 3, 2017 at 9:24 AM, Michal Hocko wrote: > On Fri 03-11-17 00:46:18, Hugh Dickins wrote: >> On Thu, 2 Nov 2017, Michal Hocko wrote: >> > From: Michal Hocko >> > >> > syzkaller has reported the following lockdep splat >> > == >> >

Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-03 Thread Michal Hocko
On Fri 03-11-17 00:46:18, Hugh Dickins wrote: > On Thu, 2 Nov 2017, Michal Hocko wrote: > > From: Michal Hocko > > > > syzkaller has reported the following lockdep splat > > == > > WARNING: possible circular locking dependency detected > > 4.13.

Re: [PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-03 Thread Hugh Dickins
On Thu, 2 Nov 2017, Michal Hocko wrote: > From: Michal Hocko > > syzkaller has reported the following lockdep splat > == > WARNING: possible circular locking dependency detected > 4.13.0-next-20170911+ #19 Not tainted > -

[PATCH 1/2] shmem: drop lru_add_drain_all from shmem_wait_for_pins

2017-11-02 Thread Michal Hocko
From: Michal Hocko syzkaller has reported the following lockdep splat == WARNING: possible circular locking dependency detected 4.13.0-next-20170911+ #19 Not tainted -- syz-executor5/6914 is tr