Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-04-04 Thread Bjorn Andersson
On Mon 03 Apr 19:38 PDT 2017, Jonathan Neusch?fer wrote: > On Mon, Mar 27, 2017 at 11:18:29PM -0700, Bjorn Andersson wrote: [..] > > However, for us to reach this point in smsm_probe() the above > > qcom_smem_get() must have returned successfully, i.e. we have SMEM in > > place so there's no need

Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-04-03 Thread Jonathan Neuschäfer
On Mon, Mar 27, 2017 at 11:18:29PM -0700, Bjorn Andersson wrote: > On Wed 15 Mar 04:43 PDT 2017, Jonathan Neusch?fer wrote: [...] > > info = qcom_smem_get(QCOM_SMEM_HOST_ANY, SMEM_SMSM_SIZE_INFO, &size); > > - if (PTR_ERR(info) == -ENOENT || size != sizeof(*info)) { > > + if (PTR_ERR(info)

Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-03-27 Thread Bjorn Andersson
On Wed 15 Mar 04:43 PDT 2017, Jonathan Neusch?fer wrote: > If qcom_smem_get or qcom_smem_alloc return -EPROBE_DEFER, let the caller > the caller handle it, instead of treating it as an error. > > Signed-off-by: Jonathan Neuschäfer > > --- > v1: > - TODO: Reading qcom_smsm_probe, I noticed memor

Re: [PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-03-17 Thread Jonathan Neuschäfer
On Wed, Mar 15, 2017 at 12:43:56PM +0100, Jonathan Neuschäfer wrote: [...] > - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths: > smsm, smsm->entries, etc. are allocated (with devm_kzalloc), but not > freed when the function returns early. This should be addressed at > so

[PATCH 1/2] soc: qcom: smsm: Handle probe deferral

2017-03-15 Thread Jonathan Neuschäfer
If qcom_smem_get or qcom_smem_alloc return -EPROBE_DEFER, let the caller the caller handle it, instead of treating it as an error. Signed-off-by: Jonathan Neuschäfer --- v1: - TODO: Reading qcom_smsm_probe, I noticed memory leaks in error paths: smsm, smsm->entries, etc. are allocated (with de