Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-27 Thread Hans-Peter Nilsson
> Date: Sat, 27 Jan 2007 21:19:29 +0100 > From: Hans-Peter Nilsson <[EMAIL PROTECTED]> > Add SPI_LSB_FIRST (still supported by spi_bitbang, I presume :) Never mind, I just noticed that I can't read. brgds, H-P - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-27 Thread Hans-Peter Nilsson
> From: David Brownell <[EMAIL PROTECTED]> > Date: Fri, 26 Jan 2007 20:21:54 -0800 > In fact, how about this one instead? It uses a bit in spi->mode > since that's pretty easy to test. And while it doesn't get rid > of the multiple conditionals when the tx buffer is null, it does > let the other

Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-27 Thread David Brownell
On Friday 26 January 2007 3:21 pm, David Brownell wrote: > > FWIW, I defined it as a single bit in that patch, because that's > > what my HW can do when the transmitter is disabled - and because > > MOSI *is* a single-valued signal. ;-) > > I wouldn't mind a single bit flag either, saying whether

Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-27 Thread David Brownell
On Saturday 27 January 2007 2:11 am, Hans-Peter Nilsson wrote: > > From: David Brownell <[EMAIL PROTECTED]> > > Date: Fri, 26 Jan 2007 15:21:15 -0800 > > > > > That flag could work in conjunction with a byte > > > > > > Or why not a 32-bit word! > > > > If a driver wants a repeating 32-bit patt

Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-27 Thread Hans-Peter Nilsson
> From: David Brownell <[EMAIL PROTECTED]> > Date: Fri, 26 Jan 2007 15:21:15 -0800 > > > That flag could work in conjunction with a byte > > > > Or why not a 32-bit word! > > If a driver wants a repeating 32-bit pattern, they should just > provide a properly initialized tx buffer. I'm suggesti

Re: [PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-26 Thread David Brownell
On Friday 26 January 2007 2:46 am, Hans-Peter Nilsson wrote: > > From: David Brownell <[EMAIL PROTECTED]> > > Date: Thu, 25 Jan 2007 05:02:56 -0800 > > > On Wednesday 24 January 2007 8:52 pm, Hans-Peter Nilsson wrote: > > > (Please CC me on replies, I'm not subscribed to LKML or the SPI list. >

[PATCH 1/2] take 2: (was-kind-of: 3/5 SPI tx_default) 2.6.20-rc6

2007-01-26 Thread Hans-Peter Nilsson
> From: David Brownell <[EMAIL PROTECTED]> > Date: Thu, 25 Jan 2007 05:02:56 -0800 > On Wednesday 24 January 2007 8:52 pm, Hans-Peter Nilsson wrote: > > (Please CC me on replies, I'm not subscribed to LKML or the SPI list. > > Thanks.) > > > > The SD/MMC SPI-based protocol isn't really duplex.