Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-11-04 Thread David Ahern
ping. did not see this one in your last push to Ingo. On 10/29/13, 10:43 AM, David Ahern wrote: feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving me nuts with the upcoming

Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-11-04 Thread David Ahern
ping. did not see this one in your last push to Ingo. On 10/29/13, 10:43 AM, David Ahern wrote: feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving me nuts with the upcoming

Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-31 Thread Ingo Molnar
* Jiri Olsa wrote: > On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote: > > feature_check needs to be invoked through call, and LDFLAGS may not be set > > so quotes are needed. > > and the problem is also when there's more than one option in LDFLAGS yeah. > > Thanks to Jiri for

Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-31 Thread Ingo Molnar
* Jiri Olsa jo...@redhat.com wrote: On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote: feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. and the problem is also when there's more than one option in LDFLAGS yeah. Thanks to Jiri

Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-29 Thread Jiri Olsa
On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote: > feature_check needs to be invoked through call, and LDFLAGS may not be set > so quotes are needed. and the problem is also when there's more than one option in LDFLAGS > > Thanks to Jiri for spotting the quotes around LDFLAGS; that

[PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-29 Thread David Ahern
feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving me nuts with the upcoming timerfd feature detection. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Peter Zijlstra Cc:

[PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-29 Thread David Ahern
feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. Thanks to Jiri for spotting the quotes around LDFLAGS; that one was driving me nuts with the upcoming timerfd feature detection. Signed-off-by: David Ahern dsah...@gmail.com Cc: Ingo Molnar

Re: [PATCH 1/2] tools/perf/build: Fix detection of non-core features

2013-10-29 Thread Jiri Olsa
On Tue, Oct 29, 2013 at 10:43:15AM -0600, David Ahern wrote: feature_check needs to be invoked through call, and LDFLAGS may not be set so quotes are needed. and the problem is also when there's more than one option in LDFLAGS Thanks to Jiri for spotting the quotes around LDFLAGS; that one