Re: [PATCH 1/2] tpm: define constants for tpm2 properties

On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 > Signed-off-by: Andrey Pronin I'm not going to apply this. The patch has no value. We only want to have a subset of constants that are *used* by the

Re: [PATCH 1/2] tpm: define constants for tpm2 properties

On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 > Signed-off-by: Andrey Pronin I'm not going to apply this. The patch has no value. We only want to have a subset of constants that are *used* by the kernel. /Jarkko > --- >

Re: [PATCH 1/2] tpm: define constants for tpm2 properties

On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 These commit messages are no good, generally for all your patches. Drop the internal change-id and provide a suitable description. Do not add dead code to the kernel, so this

Re: [PATCH 1/2] tpm: define constants for tpm2 properties

On Thu, Jul 14, 2016 at 06:07:17PM -0700, Andrey Pronin wrote: > Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 These commit messages are no good, generally for all your patches. Drop the internal change-id and provide a suitable description. Do not add dead code to the kernel, so this

[PATCH 1/2] tpm: define constants for tpm2 properties

Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 Signed-off-by: Andrey Pronin --- drivers/char/tpm/tpm.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index 8890df2..ad3b9d1 100644 ---

[PATCH 1/2] tpm: define constants for tpm2 properties

Change-Id: I47cb1793736781fbea93e5bf80b783e0ac9e8628 Signed-off-by: Andrey Pronin --- drivers/char/tpm/tpm.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index 8890df2..ad3b9d1 100644 --- a/drivers/char/tpm/tpm.h