Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Thu, Jan 26, 2017 at 08:26:19AM -0800, James Bottomley wrote: > On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > [...] > > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > > index c48255e..b77fc60 100644 > > > --- a/drivers/char/tpm/tpm.h > > > +++

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Thu, Jan 26, 2017 at 08:26:19AM -0800, James Bottomley wrote: > On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > [...] > > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > > index c48255e..b77fc60 100644 > > > --- a/drivers/char/tpm/tpm.h > > > +++

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Thu, Jan 26, 2017 at 07:18:49AM -0800, James Bottomley wrote: > On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > > On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > > > sessions are different from transient objects in that their handles > > > may not be virtualized

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Thu, Jan 26, 2017 at 07:18:49AM -0800, James Bottomley wrote: > On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > > On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > > > sessions are different from transient objects in that their handles > > > may not be virtualized

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread James Bottomley
On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: [...] > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > index c48255e..b77fc60 100644 > > --- a/drivers/char/tpm/tpm.h > > +++ b/drivers/char/tpm/tpm.h > > @@ -159,6 +159,8 @@ enum tpm2_cc_attrs { > > struct tpm_space {

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread James Bottomley
On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: [...] > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > > index c48255e..b77fc60 100644 > > --- a/drivers/char/tpm/tpm.h > > +++ b/drivers/char/tpm/tpm.h > > @@ -159,6 +159,8 @@ enum tpm2_cc_attrs { > > struct tpm_space {

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread James Bottomley
On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > > sessions are different from transient objects in that their handles > > may not be virtualized (because they're used for some hmac > > calculations). Additionally when

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread James Bottomley
On Thu, 2017-01-26 at 14:51 +0200, Jarkko Sakkinen wrote: > On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > > sessions are different from transient objects in that their handles > > may not be virtualized (because they're used for some hmac > > calculations). Additionally when

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > sessions are different from transient objects in that their handles > may not be virtualized (because they're used for some hmac > calculations). Additionally when a session is context saved, a > vestigial memory remains in the

Re: [PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-26 Thread Jarkko Sakkinen
On Mon, Jan 23, 2017 at 09:37:11PM -0800, James Bottomley wrote: > sessions are different from transient objects in that their handles > may not be virtualized (because they're used for some hmac > calculations). Additionally when a session is context saved, a > vestigial memory remains in the

[PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-23 Thread James Bottomley
sessions are different from transient objects in that their handles may not be virtualized (because they're used for some hmac calculations). Additionally when a session is context saved, a vestigial memory remains in the TPM and if it is also flushed, that will be lost and the session context

[PATCH 1/2] tpm2: add session handle context saving and restoring to the space code

2017-01-23 Thread James Bottomley
sessions are different from transient objects in that their handles may not be virtualized (because they're used for some hmac calculations). Additionally when a session is context saved, a vestigial memory remains in the TPM and if it is also flushed, that will be lost and the session context