Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Steven Rostedt
On Wed, 19 Nov 2014 17:51:49 +0100 Petr Mladek wrote: > OK, I'll put it on my todo list. Let's see who is faster ;-) And I > keep my fingers crossed about the OK from Linus and Andrew. I'll assume they are going to be OK'd. I'll place these patches in a separate branch and after I finish

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Petr Mladek
On Wed 2014-11-19 11:17:18, Steven Rostedt wrote: > On Tue, 18 Nov 2014 17:15:46 +0100 > Petr Mladek wrote: > > > On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: > > > > > > > > I don't like the fact that I did a code structure change with this > > > > patch. This patch should be just a

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Steven Rostedt
On Tue, 18 Nov 2014 17:15:46 +0100 Petr Mladek wrote: > On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: > > > > > > I don't like the fact that I did a code structure change with this > > > patch. This patch should be just a simple conversion of len to > > > seq_buf_used(). I'm going to strip

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Steven Rostedt
On Tue, 18 Nov 2014 17:15:46 +0100 Petr Mladek pmla...@suse.cz wrote: On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: I don't like the fact that I did a code structure change with this patch. This patch should be just a simple conversion of len to seq_buf_used(). I'm going to

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Petr Mladek
On Wed 2014-11-19 11:17:18, Steven Rostedt wrote: On Tue, 18 Nov 2014 17:15:46 +0100 Petr Mladek pmla...@suse.cz wrote: On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: I don't like the fact that I did a code structure change with this patch. This patch should be just a simple

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-19 Thread Steven Rostedt
On Wed, 19 Nov 2014 17:51:49 +0100 Petr Mladek pmla...@suse.cz wrote: OK, I'll put it on my todo list. Let's see who is faster ;-) And I keep my fingers crossed about the OK from Linus and Andrew. I'll assume they are going to be OK'd. I'll place these patches in a separate branch and after

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-18 Thread Petr Mladek
On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: > > > > I don't like the fact that I did a code structure change with this > > patch. This patch should be just a simple conversion of len to > > seq_buf_used(). I'm going to strip this change out and put it before > > this patch. > > > The

Re: [PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-18 Thread Petr Mladek
On Mon 2014-11-17 14:11:08, Steven Rostedt wrote: I don't like the fact that I did a code structure change with this patch. This patch should be just a simple conversion of len to seq_buf_used(). I'm going to strip this change out and put it before this patch. The function

[PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-17 Thread Steven Rostedt
> > I don't like the fact that I did a code structure change with this > patch. This patch should be just a simple conversion of len to > seq_buf_used(). I'm going to strip this change out and put it before > this patch. The function tracing_fill_pipe_page() logic is a little confusing with the

[PATCH 1/2] tracing: Clean up tracing_fill_pipe_page()

2014-11-17 Thread Steven Rostedt
I don't like the fact that I did a code structure change with this patch. This patch should be just a simple conversion of len to seq_buf_used(). I'm going to strip this change out and put it before this patch. The function tracing_fill_pipe_page() logic is a little confusing with the use