Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-12-05 Thread Petr Pavlu
On 12/1/23 15:46, Steven Rostedt wrote: > On Fri, 1 Dec 2023 15:17:35 +0100 > Petr Pavlu wrote: > >> Ok, keeping the current approach, my plan for v2 is to prepare the >> following patches: >> >> [...] >> * Fix the potential race between trace_buffered_event_enable() and >>

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-12-01 Thread Steven Rostedt
On Fri, 1 Dec 2023 15:17:35 +0100 Petr Pavlu wrote: > Ok, keeping the current approach, my plan for v2 is to prepare the > following patches: > > * Fix for the missing increment+decrement of trace_buffered_event_cnt > on the current CPU in trace_buffered_event_disable(). > > Replace

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-12-01 Thread Petr Pavlu
On 11/29/23 15:58, Steven Rostedt wrote: > On Wed, 29 Nov 2023 10:22:23 +0100 > Petr Pavlu wrote: > >> Yes, I believe this should address this potential race condition. >> >> An alternative would be instead to update >> trace_event_buffer_lock_reserve() as follows: >> >> if

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-29 Thread Petr Pavlu
On 11/28/23 16:27, Steven Rostedt wrote: > On Tue, 28 Nov 2023 16:05:00 +0100 > Petr Pavlu wrote: > >> On 11/27/23 18:41, Steven Rostedt wrote: >>> On Mon, 27 Nov 2023 16:12:47 +0100 >>> Petr Pavlu wrote: >>> The following warning appears when using buffered events: [ 203.556451]

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-28 Thread Petr Pavlu
On 11/27/23 18:41, Steven Rostedt wrote: > On Mon, 27 Nov 2023 16:12:47 +0100 > Petr Pavlu wrote: > >> The following warning appears when using buffered events: >> [ 203.556451] WARNING: CPU: 53 PID: 10220 at >> kernel/trace/ring_buffer.c:3912 ring_buffer_discard_commit+0x2eb/0x420 > > Hmm, I

Re: [PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-27 Thread Steven Rostedt
On Mon, 27 Nov 2023 16:12:47 +0100 Petr Pavlu wrote: > The following warning appears when using buffered events: > [ 203.556451] WARNING: CPU: 53 PID: 10220 at kernel/trace/ring_buffer.c:3912 > ring_buffer_discard_commit+0x2eb/0x420 Hmm, I don't have a waring on line 3912, do you have extra

[PATCH 1/2] tracing: Simplify and fix "buffered event" synchronization

2023-11-27 Thread Petr Pavlu
The following warning appears when using buffered events: [ 203.556451] WARNING: CPU: 53 PID: 10220 at kernel/trace/ring_buffer.c:3912 ring_buffer_discard_commit+0x2eb/0x420 [...] [ 203.670690] CPU: 53 PID: 10220 Comm: stress-ng-sysin Tainted: GE 6.7.0-rc2-default #4