Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path

2014-04-03 Thread Jiri Slaby
On 04/03/2014 08:10 AM, Takashi Iwai wrote: > At Wed, 02 Apr 2014 14:24:33 +0200, > Jean Delvare wrote: >> >> Le Wednesday 02 April 2014 à 12:29 +0200, Takashi Iwai a écrit : >>> ttyprintk driver calls tty_unregister_driver() wrongly in the error >>> path of tty_register_driver(). Also, setting tt

Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path

2014-04-02 Thread Takashi Iwai
At Wed, 02 Apr 2014 14:24:33 +0200, Jean Delvare wrote: > > Le Wednesday 02 April 2014 à 12:29 +0200, Takashi Iwai a écrit : > > ttyprintk driver calls tty_unregister_driver() wrongly in the error > > path of tty_register_driver(). Also, setting ttyprintk_driver to NULL > > is utterly superfluous

Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path

2014-04-02 Thread Jean Delvare
Le Wednesday 02 April 2014 à 12:29 +0200, Takashi Iwai a écrit : > ttyprintk driver calls tty_unregister_driver() wrongly in the error > path of tty_register_driver(). Also, setting ttyprintk_driver to NULL > is utterly superfluous, so let's get rid of it, too. > > Reported-by: Jean Delvare > Si

[PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path

2014-04-02 Thread Takashi Iwai
ttyprintk driver calls tty_unregister_driver() wrongly in the error path of tty_register_driver(). Also, setting ttyprintk_driver to NULL is utterly superfluous, so let's get rid of it, too. Reported-by: Jean Delvare Signed-off-by: Takashi Iwai --- drivers/char/ttyprintk.c | 2 -- 1 file chang