Re: [PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Shuah Khan
On 11/07/2017 04:21 AM, Krzysztof Opasiak wrote: > > > On 11/07/2017 11:39 AM, Arnd Bergmann wrote: >> vgadget_get_frame returns a frame number from 0 to 2046, which >> may require an expensive division operation to wrap at one lower >> than the usual number. >> >> I can't see any reason for this

Re: [PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Krzysztof Opasiak
On 11/07/2017 11:39 AM, Arnd Bergmann wrote: vgadget_get_frame returns a frame number from 0 to 2046, which may require an expensive division operation to wrap at one lower than the usual number. I can't see any reason for this, and all other drivers wrap at a power-of-two number. My best expl

[PATCH 1/2] usbip: fix off-by-one frame number calculation

2017-11-07 Thread Arnd Bergmann
vgadget_get_frame returns a frame number from 0 to 2046, which may require an expensive division operation to wrap at one lower than the usual number. I can't see any reason for this, and all other drivers wrap at a power-of-two number. My best explanation is that it was a simple typo, so I'm chan