Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-19 Thread Cindy Lu
On Tue, Jun 18, 2024 at 6:39 PM Michael S. Tsirkin wrote: > > On Mon, Jun 17, 2024 at 09:44:21AM -0700, Jakub Kicinski wrote: > > On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote: > > > > But the virtio spec doesn't allow setting the MAC... > > > > I'm probably just lost in the

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-18 Thread Michael S. Tsirkin
On Mon, Jun 17, 2024 at 09:44:21AM -0700, Jakub Kicinski wrote: > On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote: > > > But the virtio spec doesn't allow setting the MAC... > > > I'm probably just lost in the conversation but there's hypervisor side > > > and there is user/VM side,

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Jakub Kicinski
On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote: > > But the virtio spec doesn't allow setting the MAC... > > I'm probably just lost in the conversation but there's hypervisor side > > and there is user/VM side, each of them already has an interface to set > > the MAC. The MAC doesn't

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2024 at 08:20:02AM -0700, Jakub Kicinski wrote: > On Mon, 17 Jun 2024 09:47:21 -0400 Michael S. Tsirkin wrote: > > I don't know what this discussion is about, at this point. > > For better or worse, vdpa gained interfaces for provisioning > > new devices. Yes the solution space was

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Jakub Kicinski
On Mon, 17 Jun 2024 09:47:21 -0400 Michael S. Tsirkin wrote: > I don't know what this discussion is about, at this point. > For better or worse, vdpa gained interfaces for provisioning > new devices. Yes the solution space was wide but it's been there > for years so kind of too late to try and

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Michael S. Tsirkin
On Mon, Jun 17, 2024 at 03:02:43PM +0200, Jiri Pirko wrote: > Mon, Jun 17, 2024 at 01:48:02PM CEST, pa...@nvidia.com wrote: > > > >> From: Jiri Pirko > >> Sent: Monday, June 17, 2024 5:10 PM > >> > >> Mon, Jun 17, 2024 at 11:44:53AM CEST, pa...@nvidia.com wrote: > >> > > >> >> From: Jiri Pirko

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Jiri Pirko
Mon, Jun 17, 2024 at 01:48:02PM CEST, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Monday, June 17, 2024 5:10 PM >> >> Mon, Jun 17, 2024 at 11:44:53AM CEST, pa...@nvidia.com wrote: >> > >> >> From: Jiri Pirko >> >> Sent: Monday, June 17, 2024 3:09 PM >> >> >> >> Mon, Jun 17, 2024 at

RE: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Parav Pandit
> From: Jiri Pirko > Sent: Monday, June 17, 2024 5:10 PM > > Mon, Jun 17, 2024 at 11:44:53AM CEST, pa...@nvidia.com wrote: > > > >> From: Jiri Pirko > >> Sent: Monday, June 17, 2024 3:09 PM > >> > >> Mon, Jun 17, 2024 at 04:57:23AM CEST, pa...@nvidia.com wrote: > >> > > >> > > >> >> From:

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Jiri Pirko
Mon, Jun 17, 2024 at 11:44:53AM CEST, pa...@nvidia.com wrote: > >> From: Jiri Pirko >> Sent: Monday, June 17, 2024 3:09 PM >> >> Mon, Jun 17, 2024 at 04:57:23AM CEST, pa...@nvidia.com wrote: >> > >> > >> >> From: Jason Wang >> >> Sent: Monday, June 17, 2024 7:18 AM >> >> >> >> On Wed, Jun 12,

RE: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Parav Pandit
> From: Jiri Pirko > Sent: Monday, June 17, 2024 3:09 PM > > Mon, Jun 17, 2024 at 04:57:23AM CEST, pa...@nvidia.com wrote: > > > > > >> From: Jason Wang > >> Sent: Monday, June 17, 2024 7:18 AM > >> > >> On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko wrote: > >> > > >> > Wed, Jun 12, 2024 at

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-17 Thread Jiri Pirko
Mon, Jun 17, 2024 at 04:57:23AM CEST, pa...@nvidia.com wrote: > > >> From: Jason Wang >> Sent: Monday, June 17, 2024 7:18 AM >> >> On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko wrote: >> > >> > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: >> > >On Tue, 11 Jun 2024 13:32:32 +0800

RE: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-16 Thread Parav Pandit
> From: Jason Wang > Sent: Monday, June 17, 2024 7:18 AM > > On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko wrote: > > > > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > > >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > > >> Add new UAPI to support the mac address from vdpa

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-16 Thread Jason Wang
On Wed, Jun 12, 2024 at 2:30 PM Jiri Pirko wrote: > > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > >> Add new UAPI to support the mac address from vdpa tool > >> Function vdpa_nl_cmd_dev_config_set_doit() will get the > >>

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Jiri Pirko
Thu, Jun 13, 2024 at 09:50:54AM CEST, m...@redhat.com wrote: >On Thu, Jun 13, 2024 at 09:21:07AM +0200, Jiri Pirko wrote: >> Thu, Jun 13, 2024 at 08:49:25AM CEST, m...@redhat.com wrote: >> >On Wed, Jun 12, 2024 at 09:22:32AM +0200, Jiri Pirko wrote: >> >> Wed, Jun 12, 2024 at 09:15:44AM CEST,

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Cindy Lu
On Thu, Jun 13, 2024 at 2:59 PM Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > > Function vdpa_nl_cmd_dev_config_set_doit() will get the > > MAC address from the vdpa tool and then set it to the

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Michael S. Tsirkin
On Thu, Jun 13, 2024 at 09:21:07AM +0200, Jiri Pirko wrote: > Thu, Jun 13, 2024 at 08:49:25AM CEST, m...@redhat.com wrote: > >On Wed, Jun 12, 2024 at 09:22:32AM +0200, Jiri Pirko wrote: > >> Wed, Jun 12, 2024 at 09:15:44AM CEST, m...@redhat.com wrote: > >> >On Wed, Jun 12, 2024 at 08:29:53AM

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Jiri Pirko
Thu, Jun 13, 2024 at 08:49:25AM CEST, m...@redhat.com wrote: >On Wed, Jun 12, 2024 at 09:22:32AM +0200, Jiri Pirko wrote: >> Wed, Jun 12, 2024 at 09:15:44AM CEST, m...@redhat.com wrote: >> >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: >> >> Wed, Jun 12, 2024 at 03:58:10AM CEST,

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Michael S. Tsirkin
On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > Add new UAPI to support the mac address from vdpa tool > Function vdpa_nl_cmd_dev_config_set_doit() will get the > MAC address from the vdpa tool and then set it to the device. > > The usage is: vdpa dev set name vdpa_name mac

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Michael S. Tsirkin
On Wed, Jun 12, 2024 at 09:22:32AM +0200, Jiri Pirko wrote: > Wed, Jun 12, 2024 at 09:15:44AM CEST, m...@redhat.com wrote: > >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: > >> Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > >> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-13 Thread Cindy Lu
On Wed, Jun 12, 2024 at 3:12 PM Michael S. Tsirkin wrote: > > On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > > Add new UAPI to support the mac address from vdpa tool > > The patch does not do what commit log says. > Instead there's an internal API to set mac and > a UAPI to write

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Jiri Pirko
Wed, Jun 12, 2024 at 09:15:44AM CEST, m...@redhat.com wrote: >On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: >> Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: >> >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> >> Add new UAPI to support the mac address from vdpa

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Michael S. Tsirkin
On Wed, Jun 12, 2024 at 08:29:53AM +0200, Jiri Pirko wrote: > Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: > >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > >> Add new UAPI to support the mac address from vdpa tool > >> Function vdpa_nl_cmd_dev_config_set_doit() will get the

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Michael S. Tsirkin
On Tue, Jun 11, 2024 at 01:32:32PM +0800, Cindy Lu wrote: > Add new UAPI to support the mac address from vdpa tool The patch does not do what commit log says. Instead there's an internal API to set mac and a UAPI to write into config space. > Function vdpa_nl_cmd_dev_config_set_doit() will get

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-12 Thread Jiri Pirko
Wed, Jun 12, 2024 at 03:58:10AM CEST, k...@kernel.org wrote: >On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: >> Add new UAPI to support the mac address from vdpa tool >> Function vdpa_nl_cmd_dev_config_set_doit() will get the >> MAC address from the vdpa tool and then set it to the device. >>

Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-11 Thread Jakub Kicinski
On Tue, 11 Jun 2024 13:32:32 +0800 Cindy Lu wrote: > Add new UAPI to support the mac address from vdpa tool > Function vdpa_nl_cmd_dev_config_set_doit() will get the > MAC address from the vdpa tool and then set it to the device. > > The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:**

[PATCH 1/2] vdpa: support set mac address from vdpa tool

2024-06-10 Thread Cindy Lu
Add new UAPI to support the mac address from vdpa tool Function vdpa_nl_cmd_dev_config_set_doit() will get the MAC address from the vdpa tool and then set it to the device. The usage is: vdpa dev set name vdpa_name mac **:**:**:**:**:** Here is sample: root@L1# vdpa -jp dev config show vdpa0 {