Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Wed, Aug 26, 2020 at 09:33:29AM -0700, David Miller wrote: > From: Mira Ressel > Date: Wed, 26 Aug 2020 16:29:01 + > > > On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: > >> From: Mira Ressel > >> Date: Wed, 26 Aug 2020 15:20:00 + > >> > >> > I'm setting the

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread David Miller
From: Mira Ressel Date: Wed, 26 Aug 2020 16:29:01 + > On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: >> From: Mira Ressel >> Date: Wed, 26 Aug 2020 15:20:00 + >> >> > I'm setting the peer->perm_addr, which would otherwise be zero, to its >> > dev_addr, which has been

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Wed, Aug 26, 2020 at 08:28:57AM -0700, David Miller wrote: > From: Mira Ressel > Date: Wed, 26 Aug 2020 15:20:00 + > > > I'm setting the peer->perm_addr, which would otherwise be zero, to its > > dev_addr, which has been either generated randomly by the kernel or > > provided by userland

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread David Miller
From: Mira Ressel Date: Wed, 26 Aug 2020 15:20:00 + > I'm setting the peer->perm_addr, which would otherwise be zero, to its > dev_addr, which has been either generated randomly by the kernel or > provided by userland in a netlink attribute. Which by definition makes it not necessarily a

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-26 Thread Mira Ressel
On Mon, Aug 24, 2020 at 10:25:45AM -0700, David Miller wrote: > From: Mira Ressel > Date: Mon, 24 Aug 2020 14:38:26 + > > > Set the perm_addr of veth devices to whatever MAC has been assigned to > > the device. Otherwise, it remains all zero, with the consequence that > >

Re: [PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-24 Thread David Miller
From: Mira Ressel Date: Mon, 24 Aug 2020 14:38:26 + > Set the perm_addr of veth devices to whatever MAC has been assigned to > the device. Otherwise, it remains all zero, with the consequence that > ipv6_generate_stable_address() (which is used if the sysctl > net.ipv6.conf.DEV.addr_gen_mode

[PATCH 1/2] veth: Initialize dev->perm_addr

2020-08-24 Thread Mira Ressel
Set the perm_addr of veth devices to whatever MAC has been assigned to the device. Otherwise, it remains all zero, with the consequence that ipv6_generate_stable_address() (which is used if the sysctl net.ipv6.conf.DEV.addr_gen_mode is set to 2 or 3) assigns every veth interface on a host the same