Re: [PATCH 1/2] vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-11-03 Thread Alex Williamson
On Fri, 23 Oct 2020 14:34:50 +0300 Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes remaining to be > copied, but this code should return -EFAULT. > > Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement VFIO_DEVICE_GET_REGION_INFO > ioctl call") > Signed-off-by: Dan

Re: [PATCH 1/2] vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-11-03 Thread Diana Craciun OSS
On 11/2/2020 11:45 PM, Alex Williamson wrote: Thanks, Dan. Diana, can I get an ack for this? Thanks, Yes, sure, I apologize for not doing it earlier. Thanks, Diana Alex On Fri, 23 Oct 2020 14:34:50 +0300 Dan Carpenter wrote: The copy_to_user() function returns the number of bytes

Re: [PATCH 1/2] vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-11-03 Thread Diana Craciun OSS
Acked-by: Diana Craciun On 10/23/2020 2:34 PM, Dan Carpenter wrote: The copy_to_user() function returns the number of bytes remaining to be copied, but this code should return -EFAULT. Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement VFIO_DEVICE_GET_REGION_INFO ioctl call") Signed-off-by: Dan

Re: [PATCH 1/2] vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-11-02 Thread Alex Williamson
Thanks, Dan. Diana, can I get an ack for this? Thanks, Alex On Fri, 23 Oct 2020 14:34:50 +0300 Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes remaining to be > copied, but this code should return -EFAULT. > > Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement

[PATCH 1/2] vfio/fsl-mc: return -EFAULT if copy_to_user() fails

2020-10-23 Thread Dan Carpenter
The copy_to_user() function returns the number of bytes remaining to be copied, but this code should return -EFAULT. Fixes: df747bcd5b21 ("vfio/fsl-mc: Implement VFIO_DEVICE_GET_REGION_INFO ioctl call") Signed-off-by: Dan Carpenter --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 8 ++-- 1 file