Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 03:37:49PM +0800, Jason Wang wrote: > On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > > > QEMU implemented the

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Jason Wang
On Wed, Jul 10, 2024 at 2:16 PM Michael S. Tsirkin wrote: > > On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > > > QEMU implemented the configuration > > > VIRTIO_BALLOON_F_REPORTING && !

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-10 Thread Michael S. Tsirkin
On Wed, Jul 10, 2024 at 11:23:20AM +0800, Jason Wang wrote: > On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > > > QEMU implemented the configuration > > VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT > > incorrectly: it then uses vq3 for reporting, spec says

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-09 Thread Jason Wang
On Fri, Jul 5, 2024 at 6:09 PM Michael S. Tsirkin wrote: > > QEMU implemented the configuration > VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT > incorrectly: it then uses vq3 for reporting, spec says it is always 4. > > This is masked by a corresponding bug in driver: >

Re: [PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-09 Thread David Hildenbrand
On 05.07.24 12:08, Michael S. Tsirkin wrote: QEMU implemented the configuration VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT incorrectly: it then uses vq3 for reporting, spec says it is always 4. This is masked by a corresponding bug in driver: add a work around as

[PATCH 1/2] virtio_balloon: add work around for out of spec QEMU

2024-07-05 Thread Michael S. Tsirkin
QEMU implemented the configuration VIRTIO_BALLOON_F_REPORTING && ! VIRTIO_BALLOON_F_FREE_PAGE_HINT incorrectly: it then uses vq3 for reporting, spec says it is always 4. This is masked by a corresponding bug in driver: add a work around as I'm going to try and fix the driver bug.