On 11/12/2013 02:17 PM, Markus Mayer wrote:
+
+ if (!timeout)
+ dev_info(wdog->dev, "Watchdog timer stopped");
+
All that noise.
Would it be acceptable to turn these calls into dev_dbg() calls, here
and elsewhere?
Ok with me.
+
+ wdt->resolution = SECWDOG_DEFAULT_RES
On 12 November 2013 15:39, One Thousand Gnomes
wrote:
>
>> +static int bcm_kona_wdt_set_resolution_reg(struct bcm_kona_wdt *wdt)
>> +{
>> + uint32_t val;
>> + int timeout;
>> + unsigned long flags;
>> + int ret = 0;
>> +
>> + if (wdt->resolution > SECWDOG_MAX_RES)
>> +
> +static int bcm_kona_wdt_set_resolution_reg(struct bcm_kona_wdt *wdt)
> +{
> + uint32_t val;
> + int timeout;
> + unsigned long flags;
> + int ret = 0;
> +
> + if (wdt->resolution > SECWDOG_MAX_RES)
> + return -EINVAL;
> +
> + spin_lock_irqsave(&wdt->lock, fla
On 11 November 2013 09:34, Guenter Roeck wrote:
> On Fri, Nov 08, 2013 at 12:44:47PM -0800, Markus Mayer wrote:
>> This commit adds support for the watchdog timer used on the BCM281xx
>> family of SoCs.
>>
>> Signed-off-by: Markus Mayer
>> Reviewed-by: Matt Porter
>
> Overall I am a bit concerne
On Fri, Nov 08, 2013 at 12:44:47PM -0800, Markus Mayer wrote:
> This commit adds support for the watchdog timer used on the BCM281xx
> family of SoCs.
>
> Signed-off-by: Markus Mayer
> Reviewed-by: Matt Porter
Overall I am a bit concerned about the heavy use of -EAGAIN, which is a first
for wat
This commit adds support for the watchdog timer used on the BCM281xx
family of SoCs.
Signed-off-by: Markus Mayer
Reviewed-by: Matt Porter
---
drivers/watchdog/Kconfig| 21 +++
drivers/watchdog/Makefile |1 +
drivers/watchdog/bcm_kona_wdt.c | 399
6 matches
Mail list logo
