Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-16 Thread Tejun Heo
On Wed, Apr 16, 2014 at 02:32:29PM +0900, Daeseok Youn wrote: > > wq_update_unbound_numa() failure path has the following two bugs. > - alloc_unbound_pwq() is called without holding wq->mutex; > however, if the allocation fails, it jumps to out_unlock > which tries to unlock wq->mutex. > > -

Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-16 Thread Lai Jiangshan
Acked. On Wed, Apr 16, 2014 at 1:32 PM, Daeseok Youn wrote: > > wq_update_unbound_numa() failure path has the following two bugs. > - alloc_unbound_pwq() is called without holding wq->mutex; > however, if the allocation fails, it jumps to out_unlock > which tries to unlock wq->mutex. > > -

Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-16 Thread Lai Jiangshan
Acked. On Wed, Apr 16, 2014 at 1:32 PM, Daeseok Youn daeseok.y...@gmail.com wrote: wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq-mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock

Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-16 Thread Tejun Heo
On Wed, Apr 16, 2014 at 02:32:29PM +0900, Daeseok Youn wrote: wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq-mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq-mutex. - The

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq->mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq->mutex. - The function should switch to dfl_pwq on failure but didn't do so after

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq->mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq->mutex. - The function should switch to dfl_pwq on failure but didn't do so after

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq->mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq->mutex. - The function should switch to dfl_pwq on failure but didn't do so after

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq-mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq-mutex. - The function should switch to dfl_pwq on failure but didn't do so after

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq-mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq-mutex. - The function should switch to dfl_pwq on failure but didn't do so after

[PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa() failure path

2014-04-15 Thread Daeseok Youn
wq_update_unbound_numa() failure path has the following two bugs. - alloc_unbound_pwq() is called without holding wq-mutex; however, if the allocation fails, it jumps to out_unlock which tries to unlock wq-mutex. - The function should switch to dfl_pwq on failure but didn't do so after