[PATCH 1/2] x86, microcode: Do Intel microcode revision check signed v2

2014-01-24 Thread Andi Kleen
From: Andi Kleen The Intel SDM Vol 3 9.11.1 Microcode update states that the update revision field is signed. However we do the comparison unsigned, as the comparison gets promoted. Change the field to be signed, so that comparision is really signed. v2: Change field. Signed-off-by: Andi Kleen

[PATCH 1/2] x86, microcode: Do Intel microcode revision check signed v2

2013-12-12 Thread Andi Kleen
From: Andi Kleen The Intel SDM Vol 3 9.11.1 Microcode update states that the update revision field is signed. However we do the comparison unsigned, as the comparison gets promoted. Change the field to be signed, so that comparision is really signed. v2: Change field. Signed-off-by: Andi Kleen

Re: [PATCH 1/2] x86, microcode: Do Intel microcode revision check signed

2013-12-10 Thread H. Peter Anvin
On 12/10/2013 07:55 AM, Andi Kleen wrote: > On Tue, Dec 10, 2013 at 10:30:00AM -0500, Konrad Rzeszutek Wilk wrote: >> On Fri, Dec 06, 2013 at 01:04:02PM -0800, Andi Kleen wrote: >>> From: Andi Kleen >>> >>> The Intel SDM Vol 3 9.11.1 Microcode update states that >>> the update revision field is si

Re: [PATCH 1/2] x86, microcode: Do Intel microcode revision check signed

2013-12-10 Thread Andi Kleen
On Tue, Dec 10, 2013 at 10:30:00AM -0500, Konrad Rzeszutek Wilk wrote: > On Fri, Dec 06, 2013 at 01:04:02PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > The Intel SDM Vol 3 9.11.1 Microcode update states that > > the update revision field is signed. However we do the comparison > > unsig

Re: [PATCH 1/2] x86, microcode: Do Intel microcode revision check signed

2013-12-10 Thread Konrad Rzeszutek Wilk
On Fri, Dec 06, 2013 at 01:04:02PM -0800, Andi Kleen wrote: > From: Andi Kleen > > The Intel SDM Vol 3 9.11.1 Microcode update states that > the update revision field is signed. However we do the comparison > unsigned, as the comparison gets promoted. > > Use a cast to really do a signed compari

[PATCH 1/2] x86, microcode: Do Intel microcode revision check signed

2013-12-06 Thread Andi Kleen
From: Andi Kleen The Intel SDM Vol 3 9.11.1 Microcode update states that the update revision field is signed. However we do the comparison unsigned, as the comparison gets promoted. Use a cast to really do a signed comparison of the microcode revision. Signed-off-by: Andi Kleen --- arch/x86/k