Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-22 Thread Enrico Weigelt, metux IT consult
On 22.10.20 11:38, Ed W wrote: Hi, > As a compromise can you change your userland to cope with dynamic names? I > see two simple ways: > > 1) udev rule to set name as you wish can you give an example of udev rule depending on bios version ? > To recap though, the situation for many years was

Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-22 Thread kernel test robot
Hi Ed, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/master] [also build test WARNING on linus/master linux/master platform-drivers-x86/for-next v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submittin

Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-22 Thread Ed W
On 22/10/2020 10:22, Enrico Weigelt, metux IT consult wrote: > On 21.10.20 23:41, Ed Wildgoose wrote: > > Hi, > >> The pcengines bios/firmware includes ACPI tables (since 4.10.0.1) which >> will cause the kernel to automatically create led + gpio_key devices for >> the platform. This means that the

Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-22 Thread Enrico Weigelt, metux IT consult
On 21.10.20 23:41, Ed Wildgoose wrote: Hi, > The pcengines bios/firmware includes ACPI tables (since 4.10.0.1) which > will cause the kernel to automatically create led + gpio_key devices for > the platform. This means that the platform setup now creates duplicates > of all these led/key devices.

Re: [PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-21 Thread kernel test robot
Hi Ed, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/master] [also build test WARNING on linus/master linux/master platform-drivers-x86/for-next v5.9 next-20201021] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submittin

[PATCH 1/2] x86: Conditional init of pcengines leds/keys gpios

2020-10-21 Thread Ed Wildgoose
The pcengines bios/firmware includes ACPI tables (since 4.10.0.1) which will cause the kernel to automatically create led + gpio_key devices for the platform. This means that the platform setup now creates duplicates of all these led/key devices. Driver conditionally initialises leds/keys only for