Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-18 Thread Andi Kleen
> Almost everything we do prior unification is double the work. That's not correct in this case as there are no common workarounds for i386 and x86-64. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-18 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Harvey Harrison <[EMAIL PROTECTED]> writes: > > > Further towards unifying these files, add another helper in same > > spirit as is_errata93. > > The better way to handle this would be to move all these workarounds > into notifiers that only get

Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-18 Thread Ingo Molnar
* Andi Kleen [EMAIL PROTECTED] wrote: Harvey Harrison [EMAIL PROTECTED] writes: Further towards unifying these files, add another helper in same spirit as is_errata93. The better way to handle this would be to move all these workarounds into notifiers that only get registered on the

Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-18 Thread Andi Kleen
Almost everything we do prior unification is double the work. That's not correct in this case as there are no common workarounds for i386 and x86-64. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-17 Thread Andi Kleen
Harvey Harrison <[EMAIL PROTECTED]> writes: > Further towards unifying these files, add another helper > in same spirit as is_errata93. The better way to handle this would be to move all these workarounds into notifiers that only get registered on the CPUs that actually have the bugs. There is

[PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-17 Thread Harvey Harrison
Further towards unifying these files, add another helper in same spirit as is_errata93. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Incorporated HPA's suggestion of unconditional prototype for do_invalid_op. arch/x86/mm/fault_32.c | 39 ++-

[PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-17 Thread Harvey Harrison
Further towards unifying these files, add another helper in same spirit as is_errata93. Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- Incorporated HPA's suggestion of unconditional prototype for do_invalid_op. arch/x86/mm/fault_32.c | 39 ++-

Re: [PATCH 1/2] x86: add is_f00f_bug helper to fault_32|64.c

2008-01-17 Thread Andi Kleen
Harvey Harrison [EMAIL PROTECTED] writes: Further towards unifying these files, add another helper in same spirit as is_errata93. The better way to handle this would be to move all these workarounds into notifiers that only get registered on the CPUs that actually have the bugs. There is