Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-11-02 Thread Jan Beulich
>>> On 02.11.12 at 17:44, Konrad Rzeszutek Wilk wrote: > --- a/arch/x86/include/asm/xen/hypercall.h > +++ b/arch/x86/include/asm/xen/hypercall.h > @@ -359,18 +359,14 @@ HYPERVISOR_update_va_mapping(unsigned long va, pte_t > new_val, > return _hypercall4(int, update_va_mapping, va,

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-11-02 Thread Konrad Rzeszutek Wilk
On Wed, Oct 31, 2012 at 08:55:54AM +, Jan Beulich wrote: > >>> On 30.10.12 at 16:44, Konrad Rzeszutek Wilk > >>> wrote: > > On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: > >> From: Jan Beulich > >> > >> While copying the argument structures in

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-11-02 Thread Konrad Rzeszutek Wilk
On Wed, Oct 31, 2012 at 08:55:54AM +, Jan Beulich wrote: On 30.10.12 at 16:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: From: Jan Beulich jbeul...@suse.com While copying the argument structures in

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-11-02 Thread Jan Beulich
On 02.11.12 at 17:44, Konrad Rzeszutek Wilk kon...@kernel.org wrote: --- a/arch/x86/include/asm/xen/hypercall.h +++ b/arch/x86/include/asm/xen/hypercall.h @@ -359,18 +359,14 @@ HYPERVISOR_update_va_mapping(unsigned long va, pte_t new_val, return _hypercall4(int,

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-31 Thread Jan Beulich
>>> On 30.10.12 at 16:44, Konrad Rzeszutek Wilk wrote: > On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: >> From: Jan Beulich >> >> While copying the argument structures in HYPERVISOR_event_channel_op() >> and HYPERVISOR_physdev_op() into the local variable is

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-31 Thread Jan Beulich
On 30.10.12 at 16:44, Konrad Rzeszutek Wilk konrad.w...@oracle.com wrote: On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: From: Jan Beulich jbeul...@suse.com While copying the argument structures in HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-30 Thread Konrad Rzeszutek Wilk
On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: > From: Jan Beulich > > While copying the argument structures in HYPERVISOR_event_channel_op() > and HYPERVISOR_physdev_op() into the local variable is sufficiently > safe even if the actual structure is smaller than the

Re: [PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-30 Thread Konrad Rzeszutek Wilk
On Mon, Oct 29, 2012 at 10:08:17AM -0400, Konrad Rzeszutek Wilk wrote: From: Jan Beulich jbeul...@suse.com While copying the argument structures in HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local variable is sufficiently safe even if the actual structure is smaller

[PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-29 Thread Konrad Rzeszutek Wilk
From: Jan Beulich While copying the argument structures in HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local variable is sufficiently safe even if the actual structure is smaller than the container one, copying back eventual output values the same way isn't: This may

[PATCH 1/2] xen/hypercall: fix hypercall fallback code for very old hypervisors

2012-10-29 Thread Konrad Rzeszutek Wilk
From: Jan Beulich jbeul...@suse.com While copying the argument structures in HYPERVISOR_event_channel_op() and HYPERVISOR_physdev_op() into the local variable is sufficiently safe even if the actual structure is smaller than the container one, copying back eventual output values the same way