Re: [PATCH 1/2] xfs: check the return value of krealloc()

2020-11-24 Thread Leizhen (ThunderTown)
On 2020/11/24 19:51, Christoph Hellwig wrote: > On Tue, Nov 24, 2020 at 06:45:30PM +0800, Zhen Lei wrote: >> krealloc() may fail to expand the memory space. Add sanity checks to it, >> and WARN() if that really happened. > > What part of the __GFP_NOFAIL semantics isn't clear enough? Oh,

Re: [PATCH 1/2] xfs: check the return value of krealloc()

2020-11-24 Thread Christoph Hellwig
On Tue, Nov 24, 2020 at 06:45:30PM +0800, Zhen Lei wrote: > krealloc() may fail to expand the memory space. Add sanity checks to it, > and WARN() if that really happened. What part of the __GFP_NOFAIL semantics isn't clear enough?

[PATCH 1/2] xfs: check the return value of krealloc()

2020-11-24 Thread Zhen Lei
krealloc() may fail to expand the memory space. Add sanity checks to it, and WARN() if that really happened. Signed-off-by: Zhen Lei --- fs/xfs/libxfs/xfs_inode_fork.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/fs/xfs/libxfs/xfs_inode_fork.c