On Mon, Mar 12, 2007 at 03:41:17PM +1100, David Chinner wrote:
> OTOH, all other buffers are supposed to be locked when under I/O.
> This change makes a special case for the log buffers, and I'd prefer
> not to have to remember that this behaviour changed fo log buffers
> at some point in time.
>
On Wed, Mar 07, 2007 at 11:13:14AM +0100, Christoph Hellwig wrote:
> xfs_buf_get_noaddr. There's a subtile change because
> xfs_buf_get_empty returns the buffer locked, but xfs_buf_get_noaddr
> returns it unlocked. From my auditing and testing nothing in the
> log I/O code cares about this distin
Does not look to me either. Looks logical as well because these buffers
are used only in log syncing and only one thread can be ever flushing
one ICLOG and, hence, no need for protection.
Even split buffer (log->l_xbuf) is used by only ICLOG at a time,
should not matter. I don't see prot
Currently xlog_alloc allocates memory for the iclogs first, then
allocates a buffer using xfs_buf_get_empty and finally assigns
the memory to the buffer. We don't really want to do this, but
rather allocate a buffer with memory attached to it using
xfs_buf_get_noaddr. There's a subtile change bec
4 matches
Mail list logo
