On 10/30/2012 02:04 PM, Sergey Senozhatsky wrote:
On (10/29/12 10:14), Nitin Gupta wrote:
==
zram: Fix use-after-free in partial I/O case
When the compressed size of a page exceeds a threshold, the page is
stored as-is i.e. in uncompressed form. In the partial I/O i.e.
non-PAGE_SIZE'ed I/O
On (10/29/12 10:14), Nitin Gupta wrote:
> ==
> zram: Fix use-after-free in partial I/O case
>
> When the compressed size of a page exceeds a threshold, the page is
> stored as-is i.e. in uncompressed form. In the partial I/O i.e.
> non-PAGE_SIZE'ed I/O case, however, the uncompressed memory
zram_bvec_read() shared decompress functionality with zram_read_before_write()
function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by: Sergey Senozhatsky
Reviewed-by: Nitin Gupta
---
On Tue, Oct 30, 2012 at 09:58:42PM +0300, Sergey Senozhatsky wrote:
> zram: factor-out zram_decompress_page() function
What's with the indentation?
And including the Subject: again here?
>
> zram_bvec_read() shared decompress functionality with
> zram_read_before_write() function.
>
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by: Sergey
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by: Sergey
On Tue, Oct 30, 2012 at 09:58:42PM +0300, Sergey Senozhatsky wrote:
zram: factor-out zram_decompress_page() function
What's with the indentation?
And including the Subject: again here?
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
zram_bvec_read() shared decompress functionality with zram_read_before_write()
function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com
Reviewed-by: Nitin
On (10/29/12 10:14), Nitin Gupta wrote:
==
zram: Fix use-after-free in partial I/O case
When the compressed size of a page exceeds a threshold, the page is
stored as-is i.e. in uncompressed form. In the partial I/O i.e.
non-PAGE_SIZE'ed I/O case, however, the uncompressed memory was
On 10/30/2012 02:04 PM, Sergey Senozhatsky wrote:
On (10/29/12 10:14), Nitin Gupta wrote:
==
zram: Fix use-after-free in partial I/O case
When the compressed size of a page exceeds a threshold, the page is
stored as-is i.e. in uncompressed form. In the partial I/O i.e.
non-PAGE_SIZE'ed I/O
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
v3: remove debug
On (10/29/12 11:32), Nitin Gupta wrote:
>
> Nothing should be printed (even a debug only message) for
> the ZRAM_ZERO case. This case can be quite common for certain
> kinds of data and would cause a huge log spew. Also (!handle) case
> is not the same as zero-filled page case, so this message
On Mon, Oct 29, 2012 at 11:05 AM, Sergey Senozhatsky
wrote:
> zram: factor-out zram_decompress_page() function
>
> zram_bvec_read() shared decompress functionality with
> zram_read_before_write() function.
> Factor-out and make commonly used zram_decompress_page() function, which
> also
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
V2: changed debug
On (10/29/12 10:14), Nitin Gupta wrote:
>
> "Read before write" message is not valid in case ZRAM_ZERO flag is
> set. Its true only in !handle case.
>
do we actually need this message?
> Otherwise, the patch looks good to me.
>
> On a side note, zram still contains a known use-after-free bug
On 10/27/2012 09:00 AM, Sergey Senozhatsky wrote:
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which
also simplified
On 10/27/2012 09:00 AM, Sergey Senozhatsky wrote:
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which
also simplified
On (10/29/12 10:14), Nitin Gupta wrote:
Read before write message is not valid in case ZRAM_ZERO flag is
set. Its true only in !handle case.
do we actually need this message?
Otherwise, the patch looks good to me.
On a side note, zram still contains a known use-after-free bug
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
V2: changed debug
On Mon, Oct 29, 2012 at 11:05 AM, Sergey Senozhatsky
sergey.senozhat...@gmail.com wrote:
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page()
On (10/29/12 11:32), Nitin Gupta wrote:
Nothing should be printed (even a debug only message) for
the ZRAM_ZERO case. This case can be quite common for certain
kinds of data and would cause a huge log spew. Also (!handle) case
is not the same as zero-filled page case, so this message would
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
v3: remove debug
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by:
zram: factor-out zram_decompress_page() function
zram_bvec_read() shared decompress functionality with
zram_read_before_write() function.
Factor-out and make commonly used zram_decompress_page() function, which also
simplified
error handling in zram_bvec_read().
Signed-off-by:
24 matches
Mail list logo
