Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
On (10/29/12 11:32), Nitin Gupta wrote: > > Nothing should be printed (even a debug only message) for > the ZRAM_ZERO case. This case can be quite common for certain > kinds of data and would cause a huge log spew. Also (!handle) case > is not the same as zero-filled page case, so this message

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Nitin Gupta
On Mon, Oct 29, 2012 at 11:05 AM, Sergey Senozhatsky wrote: > zram: factor-out zram_decompress_page() function > > zram_bvec_read() shared decompress functionality with > zram_read_before_write() function. > Factor-out and make commonly used zram_decompress_page() function, which > also

[PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
zram: factor-out zram_decompress_page() function zram_bvec_read() shared decompress functionality with zram_read_before_write() function. Factor-out and make commonly used zram_decompress_page() function, which also simplified error handling in zram_bvec_read(). V2: changed debug

[PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
zram: factor-out zram_decompress_page() function zram_bvec_read() shared decompress functionality with zram_read_before_write() function. Factor-out and make commonly used zram_decompress_page() function, which also simplified error handling in zram_bvec_read(). V2: changed debug

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Nitin Gupta
On Mon, Oct 29, 2012 at 11:05 AM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: zram: factor-out zram_decompress_page() function zram_bvec_read() shared decompress functionality with zram_read_before_write() function. Factor-out and make commonly used zram_decompress_page()

Re: [PATCH 1/2] zram: factor-out zram_decompress_page() function (v2)

2012-10-29 Thread Sergey Senozhatsky
On (10/29/12 11:32), Nitin Gupta wrote: Nothing should be printed (even a debug only message) for the ZRAM_ZERO case. This case can be quite common for certain kinds of data and would cause a huge log spew. Also (!handle) case is not the same as zero-filled page case, so this message would