Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/21 2:23, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 11:42:10 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: >> >>> >>> On Mon, 20 Apr 2015 10:45:45 +0800 >>> Xishi Qiu wrote: >>> On 2015/4/20 9:42, Gu Zheng wrote: > Hi Xishi, > On 0

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On Mon, 20 Apr 2015 11:42:10 +0800 Xishi Qiu wrote: > On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: > > > > > On Mon, 20 Apr 2015 10:45:45 +0800 > > Xishi Qiu wrote: > > > >> On 2015/4/20 9:42, Gu Zheng wrote: > >> > >>> Hi Xishi, > >>> On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > >>> >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/20 11:29, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 10:45:45 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 9:42, Gu Zheng wrote: >> >>> Hi Xishi, >>> On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: >>> Your patches will fix your issue. But, if BIOS reports memory f

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/20 11:15, Yasuaki Ishimatsu wrote: > > On Mon, 20 Apr 2015 10:59:37 +0800 > Xishi Qiu wrote: > >> On 2015/4/20 10:09, Gu Zheng wrote: >> >>> Hi Ishimatsu, Xishi, >>> >>> On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: >>> > When hot adding memory and creating new node, the n

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On Mon, 20 Apr 2015 10:45:45 +0800 Xishi Qiu wrote: > On 2015/4/20 9:42, Gu Zheng wrote: > > > Hi Xishi, > > On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > > > >> > >> Your patches will fix your issue. > >> But, if BIOS reports memory first at node hot add, pgdat can > >> not be initialize

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On Mon, 20 Apr 2015 10:59:37 +0800 Xishi Qiu wrote: > On 2015/4/20 10:09, Gu Zheng wrote: > > > Hi Ishimatsu, Xishi, > > > > On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > > > >> > >>> When hot adding memory and creating new node, the node is offline. > >>> And after calling node_set_onli

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/20 9:42, Gu Zheng wrote: > Hi Xishi, > On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > >> >> Your patches will fix your issue. >> But, if BIOS reports memory first at node hot add, pgdat can >> not be initialized. >> >> Memory hot add flows are as follows: >> >> add_memory >> ... >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/20 10:09, Gu Zheng wrote: > Hi Ishimatsu, Xishi, > > On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> >>> When hot adding memory and creating new node, the node is offline. >>> And after calling node_set_online(), the node becomes online. >>> >>> Oh, sorry. I misread your ptaches.

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> When hot adding memory and creating new node, the node is offline. >> And after calling node_set_online(), the node becomes online. >> >> Oh, sorry. I misread your ptaches. >> > > Please ignore it... Seems also a misrea

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

Hi Ishimatsu, Xishi, On 04/20/2015 10:11 AM, Yasuaki Ishimatsu wrote: > >> When hot adding memory and creating new node, the node is offline. >> And after calling node_set_online(), the node becomes online. >> >> Oh, sorry. I misread your ptaches. >> > > Please ignore it... Seems also a misrea

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > > > > Your patches will fix your issue. > > But, if BIOS reports memory first at node hot add, pgdat can > > not be initialized. > > > > Memory hot add flows are as follows: > > > > add_memo

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

> When hot adding memory and creating new node, the node is offline. > And after calling node_set_online(), the node becomes online. > > Oh, sorry. I misread your ptaches. > Please ignore it... Thanks, Yasuaki Ishimatsu On Yasuaki Ishimatsu wrote: > > When hot adding memory and creating n

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

Hi Xishi, On 04/18/2015 04:05 AM, Yasuaki Ishimatsu wrote: > > Your patches will fix your issue. > But, if BIOS reports memory first at node hot add, pgdat can > not be initialized. > > Memory hot add flows are as follows: > > add_memory > ... > -> hotadd_new_pgdat() > ... > -> node_set

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > Your patches will fix your issue. > But, if BIOS reports memory first at node hot add, pgdat can > not be initialized. > > Memory hot add flows are as follows: > > add_memory > ... > -> hotadd_new_pgdat() > ... > -> node_set_online(nid) >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > >

Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

Your patches will fix your issue. But, if BIOS reports memory first at node hot add, pgdat can not be initialized. Memory hot add flows are as follows: add_memory ... -> hotadd_new_pgdat() ... -> node_set_online(nid) When calling hotadd_new_pgdat() for a hot added node, the node is offl

[PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages()

Hot remove nodeXX, then hot add nodeXX. If BIOS report cpu first, it will call hotadd_new_pgdat(nid, 0), this will set pgdat->node_start_pfn to 0. As nodeXX exists at boot time, so pgdat->node_spanned_pages is the same as original. Then free_area_init_core()->memmap_init() will pass a wrong start a