Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING

2013-04-01 Thread Tejun Heo
Hello, Lai. On Tue, Apr 02, 2013 at 10:17:33AM +0800, Lai Jiangshan wrote: > ->flags is hot and almost read-only(except __WQ_DRAINING). > __WQ_DRAINING bit is accessed for every queue_work(), so we add it to hot > ->flags. > > __WQ_ORDERED is read-only. > > ->freezing is cold and non-read-only.

Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING

2013-04-01 Thread Lai Jiangshan
On 04/02/2013 02:44 AM, Tejun Heo wrote: > On Sun, Mar 31, 2013 at 12:29:14AM +0800, Lai Jiangshan wrote: >> freezing is nothing related to pools, but POOL_FREEZING adds a connection, >> and causes freeze_workqueues_begin() and thaw_workqueues() complicated. >> >> Since freezing is workqueue instan

Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING

2013-04-01 Thread Tejun Heo
On Sun, Mar 31, 2013 at 12:29:14AM +0800, Lai Jiangshan wrote: > freezing is nothing related to pools, but POOL_FREEZING adds a connection, > and causes freeze_workqueues_begin() and thaw_workqueues() complicated. > > Since freezing is workqueue instance attribute, so we introduce wq->freezing > i

[PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL_FREEZING

2013-03-30 Thread Lai Jiangshan
freezing is nothing related to pools, but POOL_FREEZING adds a connection, and causes freeze_workqueues_begin() and thaw_workqueues() complicated. Since freezing is workqueue instance attribute, so we introduce wq->freezing instead and remove POOL_FREEZING. Signed-off-by: Lai Jiangshan --- kern