Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-25 Thread lijiang
在 2018年12月26日 11:36, Dave Young 写道: > On 12/26/18 at 11:24am, Dave Young wrote: > + > +KERNEL_IMAGE_SIZE > += > +The size of 'KERNEL_IMAGE_SIZE', currently unused. So remove? >>> >>> I'm not sure whether it should be removed, so i keep it. >> >> Just

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-25 Thread Dave Young
On 12/26/18 at 11:24am, Dave Young wrote: > > >> + > > >> +KERNEL_IMAGE_SIZE > > >> += > > >> +The size of 'KERNEL_IMAGE_SIZE', currently unused. > > > > > > So remove? > > > > > > > I'm not sure whether it should be removed, so i keep it. > > Just remove it. It was added by

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-25 Thread Dave Young
> >> + > >> +KERNEL_IMAGE_SIZE > >> += > >> +The size of 'KERNEL_IMAGE_SIZE', currently unused. > > > > So remove? > > > > I'm not sure whether it should be removed, so i keep it. Just remove it. It was added by Baoquan for KASLR issues, later makedumpfile reverted the

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-18 Thread Borislav Petkov
On Tue, Dec 18, 2018 at 03:31:32PM +0800, lijiang wrote: > The printk_log is used to output human readable text, it will encapsulate > header > information for log_buf, such as timestamp, syslog level, etc. Me asking those questions is supposed to hint that the explanations need improvement. But

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-17 Thread lijiang
在 2018年12月17日 21:00, Borislav Petkov 写道: > On Sun, Dec 16, 2018 at 09:16:16PM +0800, Lianbo Jiang wrote: >> +clear_idx >> += >> +The index that the next printk record to read after the last 'clear' >> +command. It indicates the first record after the last SYSLOG_ACTION >> +_CLEAR, like

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-17 Thread Borislav Petkov
On Sun, Dec 16, 2018 at 09:16:16PM +0800, Lianbo Jiang wrote: > +clear_idx > += > +The index that the next printk record to read after the last 'clear' > +command. It indicates the first record after the last SYSLOG_ACTION > +_CLEAR, like issued by 'dmesg -c'. What is that used for by the

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-17 Thread Borislav Petkov
On Sun, Dec 16, 2018 at 09:16:16PM +0800, Lianbo Jiang wrote: This... > +node_online_map > +=== > +It is a macro definition, actually it is an array node_states[N_ONLINE], > +and it represents the set of online node in a system, one bit position > +per node number. > + > +This is

Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-17 Thread Borislav Petkov
On Sun, Dec 16, 2018 at 09:16:16PM +0800, Lianbo Jiang wrote: > + > +Common variables > + > + > +init_uts_ns.name.release > + > +The number of OS release. Based on this version number, people can find > +the source code for the corresponding

[PATCH 1/2 v3] kdump: add the vmcoreinfo documentation

2018-12-16 Thread Lianbo Jiang
This document lists some variables that export to vmcoreinfo, and briefly describles what these variables indicate. It should be instructive for many people who do not know the vmcoreinfo, and it would normalize the exported variable as a standard ABI between kernel and use-space. Suggested-by: