Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-11-01 Thread Rob Landley
On Monday 31 October 2005 19:39, Matt Mackall wrote: > On Tue, Nov 01, 2005 at 11:24:27AM +1100, Paul Mackerras wrote: > > Matt, > > > > My concern about this series of patches is that it will make it harder > > to keep the kernel zlib in sync with the upstream zlib. > > This code is very long out

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-11-01 Thread Rob Landley
On Monday 31 October 2005 19:39, Matt Mackall wrote: On Tue, Nov 01, 2005 at 11:24:27AM +1100, Paul Mackerras wrote: Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. This code is very long out of sync

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Matt Mackall
On Tue, Nov 01, 2005 at 11:24:27AM +1100, Paul Mackerras wrote: > Matt, > > My concern about this series of patches is that it will make it harder > to keep the kernel zlib in sync with the upstream zlib. This code is very long out of sync with the existing upstream zlib in terms of coding style

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Paul Mackerras
Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. Are you signing up to track the upstream zlib and apply any changes made there to the kernel version, for the forseeable future? Paul.

[PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Matt Mackall
inflate: lindent and general reformatting Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> Index: tiny/lib/inflate.c === --- tiny.orig/lib/inflate.c 2005-09-27 19:31:03.0 -0700 +++ tiny/lib/inflate.c 2005-09-27

[PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Matt Mackall
inflate: lindent and general reformatting Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: tiny/lib/inflate.c === --- tiny.orig/lib/inflate.c 2005-09-27 19:31:03.0 -0700 +++ tiny/lib/inflate.c 2005-09-27

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Paul Mackerras
Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. Are you signing up to track the upstream zlib and apply any changes made there to the kernel version, for the forseeable future? Paul.

Re: [PATCH 1/20] inflate: lindent and manual formatting changes

2005-10-31 Thread Matt Mackall
On Tue, Nov 01, 2005 at 11:24:27AM +1100, Paul Mackerras wrote: Matt, My concern about this series of patches is that it will make it harder to keep the kernel zlib in sync with the upstream zlib. This code is very long out of sync with the existing upstream zlib in terms of coding style and