Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

2015-02-03 Thread Roger Quadros
On 02/02/15 19:08, Tony Lindgren wrote: > * Roger Quadros [150126 01:38]: >> On 24/01/15 22:28, Semen Protsenko wrote: >>> Some GPMC_CONFIG7 register bits marked as "RESERVED", means they >>> shouldn't be overwritten. A typical approach to handle such bits called >>> "Read-Modify-Write". Writing p

Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

2015-02-02 Thread Tony Lindgren
* Roger Quadros [150126 01:38]: > On 24/01/15 22:28, Semen Protsenko wrote: > > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they > > shouldn't be overwritten. A typical approach to handle such bits called > > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() > >

Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

2015-01-26 Thread Roger Quadros
On 24/01/15 22:28, Semen Protsenko wrote: > Some GPMC_CONFIG7 register bits marked as "RESERVED", means they > shouldn't be overwritten. A typical approach to handle such bits called > "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() > utilizes RMW technique, but implemented inc

[PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

2015-01-24 Thread Semen Protsenko
Some GPMC_CONFIG7 register bits marked as "RESERVED", means they shouldn't be overwritten. A typical approach to handle such bits called "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf() utilizes RMW technique, but implemented incorrectly. Due to obvious typo in code read registe