Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Belisko Marek
On Fri, May 1, 2015 at 4:02 PM, Mark Brown wrote: > On Fri, May 01, 2015 at 01:36:48PM +0200, Belisko Marek wrote: >> On Fri, May 1, 2015 at 1:03 PM, Mark Brown wrote: >> > On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > >> >> +/* >> >> + * Note this is a simple chip with no conf

Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Mark Brown
On Fri, May 01, 2015 at 01:36:48PM +0200, Belisko Marek wrote: > On Fri, May 1, 2015 at 1:03 PM, Mark Brown wrote: > > On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > >> +/* > >> + * Note this is a simple chip with no configuration interface, sample > >> rate is > >> + * determi

Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Belisko Marek
Hi Paul, On Fri, May 1, 2015 at 9:30 AM, Paul Bolle wrote: > Just a nit: a license mismatch. Right, I copy and paste license header from wm827 driver but add MODULE_LICENSE wrong version. I'll update in next version. Thanks. > > On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote: >> --- /dev/

Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Belisko Marek
Hi Mark, On Fri, May 1, 2015 at 1:03 PM, Mark Brown wrote: > On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > >> select SND_SOC_WM9705 if SND_SOC_AC97_BUS >> select SND_SOC_WM9712 if SND_SOC_AC97_BUS >> select SND_SOC_WM9713 if SND_SOC_AC97_BUS >> + select SN

Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Mark Brown
On Thu, Apr 30, 2015 at 11:28:01PM +0200, Marek Belisko wrote: > select SND_SOC_WM9705 if SND_SOC_AC97_BUS > select SND_SOC_WM9712 if SND_SOC_AC97_BUS > select SND_SOC_WM9713 if SND_SOC_AC97_BUS > + select SND_SOC_GTM601 > help > +config SND_SOC_GTM601 > + trista

Re: [PATCH 1/3] ASoC: Add gtm601 codec driver

2015-05-01 Thread Paul Bolle
Just a nit: a license mismatch. On Thu, 2015-04-30 at 23:28 +0200, Marek Belisko wrote: > --- /dev/null > +++ b/sound/soc/codecs/gtm601.c > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the

[PATCH 1/3] ASoC: Add gtm601 codec driver

2015-04-30 Thread Marek Belisko
This driver add PCM interface to a GTM601 UMTS modem chip. There is no configuration interface. Signed-off-by: Marek Belisko --- sound/soc/codecs/Kconfig | 4 ++ sound/soc/codecs/Makefile | 2 + sound/soc/codecs/gtm601.c | 106 ++ 3 files changed,