Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-11 Thread Mark Brown
On Tue, Jul 11, 2017 at 02:13:31PM +0200, Sebastian Reichel wrote: > How is having a subnode without a compatible property different? You don't *need* to have the subnode, I was only mentioning that if for some reason it was super useful for organizing the properties. signature.asc Description:

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-11 Thread Sebastian Reichel
Hi, On Tue, Jul 11, 2017 at 11:49:11AM +0100, Mark Brown wrote: > On Mon, Jul 10, 2017 at 10:15:41PM -0700, Tony Lindgren wrote: > > * Mark Brown [170710 10:52]: > > > > If this is part of a MFD shouldn't the parent device register it without > > > it needing to be in the DT? > > > Having the M

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-11 Thread Mark Brown
On Mon, Jul 10, 2017 at 10:15:41PM -0700, Tony Lindgren wrote: > * Mark Brown [170710 10:52]: > > If this is part of a MFD shouldn't the parent device register it without > > it needing to be in the DT? > Having the MFD core part just do devm_of_platform_populate() leaves out > dependencies betw

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-10 Thread Tony Lindgren
* Mark Brown [170710 10:52]: > On Fri, Jul 07, 2017 at 06:42:27PM +0200, Sebastian Reichel wrote: > > +#ifdef CONFIG_OF > > +static const struct of_device_id cpcap_audio_of_match[] = { > > + { .compatible = "motorola,cpcap-audio-codec", }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, cpcap_a

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-10 Thread Mark Brown
On Fri, Jul 07, 2017 at 06:42:27PM +0200, Sebastian Reichel wrote: > snd-soc-cq93vc-objs := cq93vc.o > +snd-soc-cpcap-objs := cpcap.o Please keep Kconfig and Makefile lexically sorted. > +static int cpcap_audio_write(struct cpcap_audio *cpcap, > + u16 reg, u16 mask, u16

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-10 Thread Rob Herring
On Fri, Jul 07, 2017 at 06:42:27PM +0200, Sebastian Reichel wrote: > Motorola CPCAP is a PMIC with audio functionality, that can be > found on Motorola Droid 4 and probably a few other phones from > Motorola's Droid series. > > The driver has been written from scratch using Motorola's Android > dr

Re: [PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-08 Thread Tony Lindgren
* Sebastian Reichel [170707 09:43]: > Motorola CPCAP is a PMIC with audio functionality, that can be > found on Motorola Droid 4 and probably a few other phones from > Motorola's Droid series. > > The driver has been written from scratch using Motorola's Android > driver, register dumps from runn

[PATCH 1/3] ASoC: codec: cpcap: new codec

2017-07-07 Thread Sebastian Reichel
Motorola CPCAP is a PMIC with audio functionality, that can be found on Motorola Droid 4 and probably a few other phones from Motorola's Droid series. The driver has been written from scratch using Motorola's Android driver, register dumps from running Android and datasheet for NXP MC13783UG (whic