[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-06-10 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by:

[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-06-10 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella ---

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-09 Thread Mark Brown
On Mon, May 09, 2016 at 12:05:56PM +, Opensource [Adam Thomson] wrote: > On May 06, 2016, 17:06, Mark Brown wrote: > > No, not really - your DT is fairly unusual in how it's done and the lack > > of ACPI helpers is not a good sign on that side. The _DSD things are > > really only supposed to

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-09 Thread Mark Brown
On Mon, May 09, 2016 at 12:05:56PM +, Opensource [Adam Thomson] wrote: > On May 06, 2016, 17:06, Mark Brown wrote: > > No, not really - your DT is fairly unusual in how it's done and the lack > > of ACPI helpers is not a good sign on that side. The _DSD things are > > really only supposed to

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-09 Thread Opensource [Adam Thomson]
On May 06, 2016, 17:06, Mark Brown wrote: > No, not really - your DT is fairly unusual in how it's done and the lack > of ACPI helpers is not a good sign on that side. The _DSD things are > really only supposed to work for simple properties on devices. It's unusual in that there's a child node

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-09 Thread Opensource [Adam Thomson]
On May 06, 2016, 17:06, Mark Brown wrote: > No, not really - your DT is fairly unusual in how it's done and the lack > of ACPI helpers is not a good sign on that side. The _DSD things are > really only supposed to work for simple properties on devices. It's unusual in that there's a child node

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Mark Brown
On Fri, May 06, 2016 at 02:33:04PM +, Opensource [Adam Thomson] wrote: > On May 06, 2016, 13:27, Mark Brown wrote: > > Is this *really* sensible? DT idioms don't always match up with ACPI > > idioms well and this isn't a trivial DT binding. > For what we're doing here, both DT and ACPI

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Mark Brown
On Fri, May 06, 2016 at 02:33:04PM +, Opensource [Adam Thomson] wrote: > On May 06, 2016, 13:27, Mark Brown wrote: > > Is this *really* sensible? DT idioms don't always match up with ACPI > > idioms well and this isn't a trivial DT binding. > For what we're doing here, both DT and ACPI

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 13:27, Mark Brown wrote: > > This change converts the driver from using the of_* functions to using > > the device_* and fwnode_* functions for accssing DT related data. > > This is in preparation for updates to support ACPI based initialisation. > > Is this *really* sensible?

RE: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Opensource [Adam Thomson]
On May 06, 2016, 13:27, Mark Brown wrote: > > This change converts the driver from using the of_* functions to using > > the device_* and fwnode_* functions for accssing DT related data. > > This is in preparation for updates to support ACPI based initialisation. > > Is this *really* sensible?

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Mark Brown
On Thu, May 05, 2016 at 11:53:04AM +0100, Adam Thomson wrote: > This change converts the driver from using the of_* functions to using > the device_* and fwnode_* functions for accssing DT related data. > This is in preparation for updates to support ACPI based initialisation. Is this *really*

Re: [PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-06 Thread Mark Brown
On Thu, May 05, 2016 at 11:53:04AM +0100, Adam Thomson wrote: > This change converts the driver from using the of_* functions to using > the device_* and fwnode_* functions for accssing DT related data. > This is in preparation for updates to support ACPI based initialisation. Is this *really*

[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-05 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by:

[PATCH 1/3] ASoC: da7219: Convert driver to use generic device/fwnode functions

2016-05-05 Thread Adam Thomson
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation. Signed-off-by: Adam Thomson Tested-by: Sathyanarayana Nujella ---