RE: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-14 Thread Ryan Lee
project.org; linux- >ker...@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and >DSP_B format > >On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee <ryans@maximintegrat

RE: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-14 Thread Ryan Lee
er...@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and >DSP_B format > >On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- > >Please make an effort to write changel

Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-14 Thread Mark Brown
On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- Please make an effort to write changelogs that clearly describe the change you're making. This is doing way more than just implementing DSP mode, it's also adding a fairly

Re: [PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-14 Thread Mark Brown
On Mon, Sep 11, 2017 at 09:12:18AM -0700, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- Please make an effort to write changelogs that clearly describe the change you're making. This is doing way more than just implementing DSP mode, it's also adding a fairly complicated set_tdm_slot()

[PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-11 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changelog: Added support for DSP_A and DSP_B format Added 'max98927_dai_tdm_slot' function to set proper slot configuration. Moved max98927->iface out of switch statement to avoid line duplication. Added variable 'tdm_mode' to avoid BCLK

[PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-11 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changelog: Added support for DSP_A and DSP_B format Added 'max98927_dai_tdm_slot' function to set proper slot configuration. Moved max98927->iface out of switch statement to avoid line duplication. Added variable 'tdm_mode' to avoid BCLK overwrite after

[PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-01 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changelog: Added support for DSP_A and DSP_B format Added 'max98927_dai_tdm_slot' function to configure for proper slot configuration. Moved max98927->iface out of switch statement to avoid line duplication.

[PATCH 1/3] ASoC: max98927: Added support for DSP_A and DSP_B format

2017-09-01 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changelog: Added support for DSP_A and DSP_B format Added 'max98927_dai_tdm_slot' function to configure for proper slot configuration. Moved max98927->iface out of switch statement to avoid line duplication. Added variable 'tdm_mode' to avoid