Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-10-01 Thread Mark Brown
On Thu, Sep 13, 2012 at 03:40:11PM -0700, Andrey Smirnov wrote: > + core = kzalloc(sizeof(*core), GFP_KERNEL); devm_kzalloc() > + if (!core) { > + pr_err("si476x-core: failed to allocate " \ > +"'struct si476x_core'\n"); > + return -ENOMEM; > +

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 18:33:45 andrey.smir...@convergeddevices.net wrote: > On 09/21/2012 12:31 AM, Hans Verkuil wrote: > > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: > >> On 09/13/2012 11:44 PM, Hans Verkuil wrote: > >>> Hi Andrey! > >>> > >>> Thanks for postin

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread andrey.smir...@convergeddevices.net
On 09/21/2012 12:31 AM, Hans Verkuil wrote: > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: >> On 09/13/2012 11:44 PM, Hans Verkuil wrote: >>> Hi Andrey! >>> >>> Thanks for posting this driver. One request for the future: please split >>> this >>> patch up in smaller

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread Hans Verkuil
On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: > On 09/13/2012 11:44 PM, Hans Verkuil wrote: > > Hi Andrey! > > > > Thanks for posting this driver. One request for the future: please split > > this > > patch up in smaller pieces: one for each c source for example. Tha

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-20 Thread andrey.smir...@convergeddevices.net
On 09/13/2012 11:44 PM, Hans Verkuil wrote: > Hi Andrey! > > Thanks for posting this driver. One request for the future: please split this > patch up in smaller pieces: one for each c source for example. That makes it > easier to review. Will do for next version. > + > +/** > + * __core_send_comm

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-13 Thread Hans Verkuil
Hi Andrey! Thanks for posting this driver. One request for the future: please split this patch up in smaller pieces: one for each c source for example. That makes it easier to review. On Fri September 14 2012 00:40:11 Andrey Smirnov wrote: > This patch adds a core driver for Silicon Laboratories