Re: [PATCH 1/3] Fix use of skb after netif_rx

2007-12-10 Thread David Miller
From: Julia Lawall <[EMAIL PROTECTED]> Date: Sun, 9 Dec 2007 21:02:31 +0100 (CET) > From: Julia Lawall <[EMAIL PROTECTED]> > > Recently, Wang Chen submitted a patch > (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb) > after a subsequent reference to skb, because netif_rx

Re: [PATCH 1/3] Fix use of skb after netif_rx

2007-12-10 Thread Jeff Dike
On Sun, Dec 09, 2007 at 09:02:31PM +0100, Julia Lawall wrote: > Recently, Wang Chen submitted a patch > (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb) > after a subsequent reference to skb, because netif_rx may call kfree_skb on > its argument. The same problem occurs i

[PATCH 1/3] Fix use of skb after netif_rx

2007-12-09 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> Recently, Wang Chen submitted a patch (d30f53aeb31d453a5230f526bea592af07944564) to move a call to netif_rx(skb) after a subsequent reference to skb, because netif_rx may call kfree_skb on its argument. The same problem occurs in some other drivers as well.