Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Pavel Machek
On Tue 2015-06-09 09:49:35, Dmitry Torokhov wrote: > On Tue, Jun 09, 2015 at 03:19:55PM +0200, Samuel Thibault wrote: > > Hello, > > > > Dmitry Torokhov, le Mon 08 Jun 2015 14:43:08 -0700, a écrit : > > > 1. Instead of making LED class devices part of the input device they are > > > implemented as

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Dmitry Torokhov
On Tue, Jun 09, 2015 at 07:22:31PM +0200, Samuel Thibault wrote: > Dmitry Torokhov, le Tue 09 Jun 2015 09:49:35 -0700, a écrit : > > > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > > + [LED_CAPSL] = { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > > > +

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Samuel Thibault
Dmitry Torokhov, le Tue 09 Jun 2015 09:49:35 -0700, a écrit : > > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > + [LED_CAPSL] = { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > > + [LED_SCROLLL] = { "scroll-lock", VT_TRIGGER("kbd-scrollock") }, > > > > I'd tend to th

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Samuel Thibault
Dmitry Torokhov, le Tue 09 Jun 2015 09:50:52 -0700, a écrit : > On Tue, Jun 09, 2015 at 03:27:34PM +0200, Samuel Thibault wrote: > > Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a écrit : > > > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > > + [LED_CAPSL]

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Dmitry Torokhov
On Tue, Jun 09, 2015 at 03:19:55PM +0200, Samuel Thibault wrote: > Hello, > > Dmitry Torokhov, le Mon 08 Jun 2015 14:43:08 -0700, a écrit : > > 1. Instead of making LED class devices part of the input device they are > > implemented as an input handler (and thus are completely separate from > > in

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Dmitry Torokhov
On Tue, Jun 09, 2015 at 03:27:34PM +0200, Samuel Thibault wrote: > Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a écrit : > > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > + [LED_CAPSL] = { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > > + [LED_SCROLLL] = { "s

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Samuel Thibault
Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a écrit : > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > + [LED_CAPSL] = { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > + [LED_SCROLLL] = { "scroll-lock", VT_TRIGGER("kbd-scrollock") }, > > I'd tend to think

Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-09 Thread Samuel Thibault
Hello, Dmitry Torokhov, le Mon 08 Jun 2015 14:43:08 -0700, a écrit : > 1. Instead of making LED class devices part of the input device they are > implemented as an input handler (and thus are completely separate from > input core). That's nicer indeed. Not defining triggers per LED however does

[PATCH 1/3] Input: export LEDs as class devices in sysfs

2015-06-08 Thread Dmitry Torokhov
From: Samuel Thibault This change creates a new input handler called "leds" that exports LEDs on input devices as standard LED class devices in sysfs and allows controlling their ptate via sysfs or via any of the standard LED triggers. This allows to re-purpose and reassign LDEs on the keyboards