Re: [PATCH 1/3] Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL"

2021-04-07 Thread Johan Hovold
On Wed, Apr 07, 2021 at 01:04:31PM +0200, Anthony Mallet wrote: > On Wednesday 7 Apr 2021, at 12:28, Johan Hovold wrote: > > With HZ=250, the default 0.5 second value of close_delay is converted to > > 125 jiffies when set and is converted back to 50 centiseconds by > > TIOCGSERIAL as expected (no

[PATCH 1/3] Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL"

2021-04-07 Thread Anthony Mallet
On Wednesday 7 Apr 2021, at 12:28, Johan Hovold wrote: > With HZ=250, the default 0.5 second value of close_delay is converted to > 125 jiffies when set and is converted back to 50 centiseconds by > TIOCGSERIAL as expected (not 12 cs as was claimed). It was "12" (instead of 50) because the conver

[PATCH 1/3] Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL"

2021-04-07 Thread Johan Hovold
This reverts commit b401f8c4f492cbf74f3f59c9141e5be3071071bb. The offending commit claimed that trying to set the values reported back by TIOCGSERIAL as a regular user could result in an -EPERM error when HZ is 250, but that was never the case. With HZ=250, the default 0.5 second value of close_d