Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-22 Thread Doug Anderson
Hi, On Mon, Aug 20, 2018 at 11:17 AM, Stephen Boyd wrote: >> + qfprom@784000 { > > This doesn't match reg property. > >> + compatible = "qcom,qfprom"; >> + reg = <0x78 0x8ff>; > > Because this should be 0x784000? Thank you for

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-22 Thread Doug Anderson
Hi, On Mon, Aug 20, 2018 at 11:17 AM, Stephen Boyd wrote: >> + qfprom@784000 { > > This doesn't match reg property. > >> + compatible = "qcom,qfprom"; >> + reg = <0x78 0x8ff>; > > Because this should be 0x784000? Thank you for

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-20 Thread Stephen Boyd
Quoting Douglas Anderson (2018-08-10 14:51:48) > From: Manu Gautam > > This adds nodes for USB and related PHYs. > > Signed-off-by: Manu Gautam > [dianders: reworked quite a bit] > Signed-off-by: Douglas Anderson > --- One question below, otherwise Reviewed-by: Stephen Boyd > > Changes

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-20 Thread Stephen Boyd
Quoting Douglas Anderson (2018-08-10 14:51:48) > From: Manu Gautam > > This adds nodes for USB and related PHYs. > > Signed-off-by: Manu Gautam > [dianders: reworked quite a bit] > Signed-off-by: Douglas Anderson > --- One question below, otherwise Reviewed-by: Stephen Boyd > > Changes

[PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-10 Thread Douglas Anderson
From: Manu Gautam This adds nodes for USB and related PHYs. Signed-off-by: Manu Gautam [dianders: reworked quite a bit] Signed-off-by: Douglas Anderson --- Changes in v2: - Use "0x784000" for qfprom rather than "0x78" as per docs. - Add calibration for 2nd USB port too

[PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-08-10 Thread Douglas Anderson
From: Manu Gautam This adds nodes for USB and related PHYs. Signed-off-by: Manu Gautam [dianders: reworked quite a bit] Signed-off-by: Douglas Anderson --- Changes in v2: - Use "0x784000" for qfprom rather than "0x78" as per docs. - Add calibration for 2nd USB port too

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-07-12 Thread Doug Anderson
Hi, On Tue, Jul 10, 2018 at 3:02 PM, Douglas Anderson wrote: > From: Manu Gautam > > This adds nodes for USB and related PHYs. > > Signed-off-by: Manu Gautam > [dianders: reworked quite a bit] > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 189

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-07-12 Thread Doug Anderson
Hi, On Tue, Jul 10, 2018 at 3:02 PM, Douglas Anderson wrote: > From: Manu Gautam > > This adds nodes for USB and related PHYs. > > Signed-off-by: Manu Gautam > [dianders: reworked quite a bit] > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 189

[PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-07-10 Thread Douglas Anderson
From: Manu Gautam This adds nodes for USB and related PHYs. Signed-off-by: Manu Gautam [dianders: reworked quite a bit] Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 189 +++ 1 file changed, 189 insertions(+) diff --git

[PATCH 1/3] arm64: dts: qcom: sdm845: Add USB-related nodes

2018-07-10 Thread Douglas Anderson
From: Manu Gautam This adds nodes for USB and related PHYs. Signed-off-by: Manu Gautam [dianders: reworked quite a bit] Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 189 +++ 1 file changed, 189 insertions(+) diff --git