Re: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void

2019-09-13 Thread Kalle Valo
zhong jiang wrote: > brcms_c_set_mac do not need return value to cope with different > cases. And change functon return type to void. > > Signed-off-by: zhong jiang I just don't see the benefit from changing the function to return void. And if we ever add error handling to the function we nee

[PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void

2019-09-12 Thread zhong jiang
brcms_c_set_mac do not need return value to cope with different cases. And change functon return type to void. Signed-off-by: zhong jiang --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/broa