On Thu, Jan 21, 2021 at 12:13 AM Greg KH wrote:
>
> On Wed, Jan 20, 2021 at 11:38:57AM -0800, Dan Williams wrote:
> > -void cdev_del(struct cdev *p)
> > +void cdev_del(struct cdev *cdev)
> > {
> > - cdev_unmap(p->dev, p->count);
> > - kobject_put(&p->kobj);
> > + cdev_unmap(cdev->dev,
On Wed, Jan 20, 2021 at 11:38:57AM -0800, Dan Williams wrote:
> -void cdev_del(struct cdev *p)
> +void cdev_del(struct cdev *cdev)
> {
> - cdev_unmap(p->dev, p->count);
> - kobject_put(&p->kobj);
> + cdev_unmap(cdev->dev, cdev->count);
> + kobject_put(&cdev->kobj);
After Christoph
On Wed, Jan 20, 2021 at 12:20 PM Dan Williams wrote:
>
> On Wed, Jan 20, 2021 at 11:46 AM Christoph Hellwig wrote:
> >
> > The subject doesn't make any sense to me.
> >
> > But thn again queued sound really weird. You just have a managed
> > API with a refcount and synchronization, right?
>
> Co
On Wed, Jan 20, 2021 at 11:51 AM Logan Gunthorpe wrote:
>
>
>
>
> On 2021-01-20 12:38 p.m., Dan Williams wrote:
> > ...common reference count handling scenarios were addressed, but the
> > shutdown-synchronization problem was only mentioned as something driver
> > developers need to be aware in th
On Wed, Jan 20, 2021 at 11:46 AM Christoph Hellwig wrote:
>
> The subject doesn't make any sense to me.
>
> But thn again queued sound really weird. You just have a managed
> API with a refcount and synchronization, right?
Correct.
"queue" was in reference to the way q_usage_count behaves, but
On 2021-01-20 12:38 p.m., Dan Williams wrote:
> ...common reference count handling scenarios were addressed, but the
> shutdown-synchronization problem was only mentioned as something driver
> developers need to be aware in the following note:
>
> NOTE: This guarantees that associated sysf
The subject doesn't make any sense to me.
But thn again queued sound really weird. You just have a managed
API with a refcount and synchronization, right?
procfs and debugfs already support these kind of managed ops, kinda sad
to duplicate this concept yet another time.
> +static long cdev_queu
The cdev api aims to preclude many common mistakes of driver developers
with ioctl interface lifetime and lookup. However, one common concern
that is left to driver implementers to handle manually is synchronizing
device shutdown with in-flight calls to file_operations handlers.
Starting with comm
8 matches
Mail list logo
