Re: [PATCH 1/3] clocksource: clean up clocksource_select

2013-07-04 Thread Alex Shi
On 07/04/2013 06:27 PM, Thomas Gleixner wrote: >> > BTW, why we allow user override a second best clocksource? I mean user >> > can override the tsc with hpet. because undetected unstable tsc? > The user can decide to override with clocksource=jiffies if he wants > for testing purposes. That wont s

Re: [PATCH 1/3] clocksource: clean up clocksource_select

2013-07-04 Thread Thomas Gleixner
On Thu, 4 Jul 2013, Alex Shi wrote: > > We need this check and it is completely unrelated to the problem > > you're trying to solve. > > > > Assume the following: > > > >System boots with clocksource A and switches into highres mode. > >Now clocksource B gets registered and B is n

Re: [PATCH 1/3] clocksource: clean up clocksource_select

2013-07-04 Thread Alex Shi
> We need this check and it is completely unrelated to the problem > you're trying to solve. > > Assume the following: > >System boots with clocksource A and switches into highres mode. >Now clocksource B gets registered and B is not highres capable. > >clocksource_find_

Re: [PATCH 1/3] clocksource: clean up clocksource_select

2013-07-04 Thread Thomas Gleixner
On Thu, 4 Jul 2013, Alex Shi wrote: > After clocksource_find_best() introduced, it is impossible to get into > some code path. so clean them up. That's wrong. > Signed-off-by: Alex Shi > --- > kernel/time/clocksource.c | 16 +--- > 1 file changed, 1 insertion(+), 15 deletions(-) >

[PATCH 1/3] clocksource: clean up clocksource_select

2013-07-03 Thread Alex Shi
After clocksource_find_best() introduced, it is impossible to get into some code path. so clean them up. Signed-off-by: Alex Shi --- kernel/time/clocksource.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.