Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-03-03 Thread Viresh Kumar
On 1 March 2014 06:39, Rafael J. Wysocki wrote: > And while I'm at it, can we *please* avoid adding new #ifdef blocks into > function bodies? > > Please introduce a wrapper around __find_governor() returning NULL for > CONFIG_HOTPLUG_CPU unset. I have tried fixing all the suggestions you gave

Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-03-03 Thread Viresh Kumar
On 1 March 2014 06:39, Rafael J. Wysocki r...@rjwysocki.net wrote: And while I'm at it, can we *please* avoid adding new #ifdef blocks into function bodies? Please introduce a wrapper around __find_governor() returning NULL for CONFIG_HOTPLUG_CPU unset. I have tried fixing all the

Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-28 Thread Rafael J. Wysocki
On Tuesday, February 25, 2014 02:20:09 PM Viresh Kumar wrote: > We call __find_governor() during addition of first CPU of every policy to find > the last governor used for this CPU before it was hotplugged-out. > > After that we call cpufreq_parse_governor() in cpufreq_init_policy() either >

Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-28 Thread Rafael J. Wysocki
On Tuesday, February 25, 2014 02:20:09 PM Viresh Kumar wrote: > We call __find_governor() during addition of first CPU of every policy to find > the last governor used for this CPU before it was hotplugged-out. > > After that we call cpufreq_parse_governor() in cpufreq_init_policy() either >

Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-28 Thread Rafael J. Wysocki
On Tuesday, February 25, 2014 02:20:09 PM Viresh Kumar wrote: We call __find_governor() during addition of first CPU of every policy to find the last governor used for this CPU before it was hotplugged-out. After that we call cpufreq_parse_governor() in cpufreq_init_policy() either with

Re: [PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-28 Thread Rafael J. Wysocki
On Tuesday, February 25, 2014 02:20:09 PM Viresh Kumar wrote: We call __find_governor() during addition of first CPU of every policy to find the last governor used for this CPU before it was hotplugged-out. After that we call cpufreq_parse_governor() in cpufreq_init_policy() either with

[PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-25 Thread Viresh Kumar
We call __find_governor() during addition of first CPU of every policy to find the last governor used for this CPU before it was hotplugged-out. After that we call cpufreq_parse_governor() in cpufreq_init_policy() either with this governor or default governor. And right after that

[PATCH 1/3] cpufreq: move call to __find_governor() to cpufreq_init_policy()

2014-02-25 Thread Viresh Kumar
We call __find_governor() during addition of first CPU of every policy to find the last governor used for this CPU before it was hotplugged-out. After that we call cpufreq_parse_governor() in cpufreq_init_policy() either with this governor or default governor. And right after that policy-governor