Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 14-11-16, 09:36, Viresh Kumar wrote: > On 13-11-16, 15:46, Rafael J. Wysocki wrote: > > That's only going to happen in the next patch, though, right? It > > wouldn't hurt to write that in the changelog too. > > Sure. > > > Besides, I'm not actually sure if starting/stopping the kthread in >

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 14-11-16, 09:36, Viresh Kumar wrote: > On 13-11-16, 15:46, Rafael J. Wysocki wrote: > > That's only going to happen in the next patch, though, right? It > > wouldn't hurt to write that in the changelog too. > > Sure. > > > Besides, I'm not actually sure if starting/stopping the kthread in >

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 13-11-16, 15:46, Rafael J. Wysocki wrote: > That's only going to happen in the next patch, though, right? It > wouldn't hurt to write that in the changelog too. Sure. > Besides, I'm not actually sure if starting/stopping the kthread in > sugov_policy_alloc/free() is a good idea. It sort of

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 13-11-16, 15:46, Rafael J. Wysocki wrote: > That's only going to happen in the next patch, though, right? It > wouldn't hurt to write that in the changelog too. Sure. > Besides, I'm not actually sure if starting/stopping the kthread in > sugov_policy_alloc/free() is a good idea. It sort of

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Sat, Nov 12, 2016 at 6:19 AM, Viresh Kumar wrote: > On 12 November 2016 at 03:28, Rafael J. Wysocki wrote: > >>> @@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy) >>> struct sugov_tunables *tunables =

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Sat, Nov 12, 2016 at 6:19 AM, Viresh Kumar wrote: > On 12 November 2016 at 03:28, Rafael J. Wysocki wrote: > >>> @@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy) >>> struct sugov_tunables *tunables = sg_policy->tunables; >>> unsigned int count; >>> >>>

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 12 November 2016 at 03:28, Rafael J. Wysocki wrote: >> @@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy) >> struct sugov_tunables *tunables = sg_policy->tunables; >> unsigned int count; >> >> -

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On 12 November 2016 at 03:28, Rafael J. Wysocki wrote: >> @@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy) >> struct sugov_tunables *tunables = sg_policy->tunables; >> unsigned int count; >> >> - cpufreq_disable_fast_switch(policy); >> - > > ->but

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 10:52:27PM +0100, Rafael J. Wysocki wrote: > On Fri, Nov 11, 2016 at 3:19 PM, Peter Zijlstra wrote: > > On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: > >> @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) > >> >

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 10:52:27PM +0100, Rafael J. Wysocki wrote: > On Fri, Nov 11, 2016 at 3:19 PM, Peter Zijlstra wrote: > > On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: > >> @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) > >> > >> out: > >>

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 11:22 AM, Viresh Kumar wrote: > The fast_switch_enabled flag will be used a bit earlier while converting > the schedutil governor to use kthread worker. > > Prepare for that by moving the call to enable it to the beginning of > sugov_init(). Fair

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 11:22 AM, Viresh Kumar wrote: > The fast_switch_enabled flag will be used a bit earlier while converting > the schedutil governor to use kthread worker. > > Prepare for that by moving the call to enable it to the beginning of > sugov_init(). Fair enough -> >

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 3:19 PM, Peter Zijlstra wrote: > On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: >> @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) >> >> out: >> mutex_unlock(_tunables_lock); >> - >> -

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 3:19 PM, Peter Zijlstra wrote: > On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: >> @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) >> >> out: >> mutex_unlock(_tunables_lock); >> - >> - cpufreq_enable_fast_switch(policy);

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: > @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) > > out: > mutex_unlock(_tunables_lock); > - > - cpufreq_enable_fast_switch(policy); > return 0; > > fail: > @@ -468,6 +470,10 @@ static

Re: [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

On Fri, Nov 11, 2016 at 03:52:21PM +0530, Viresh Kumar wrote: > @@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy) > > out: > mutex_unlock(_tunables_lock); > - > - cpufreq_enable_fast_switch(policy); > return 0; > > fail: > @@ -468,6 +470,10 @@ static

[PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

The fast_switch_enabled flag will be used a bit earlier while converting the schedutil governor to use kthread worker. Prepare for that by moving the call to enable it to the beginning of sugov_init(). Signed-off-by: Viresh Kumar --- kernel/sched/cpufreq_schedutil.c |

[PATCH 1/3] cpufreq: schedutil: enable fast switch earlier

The fast_switch_enabled flag will be used a bit earlier while converting the schedutil governor to use kthread worker. Prepare for that by moving the call to enable it to the beginning of sugov_init(). Signed-off-by: Viresh Kumar --- kernel/sched/cpufreq_schedutil.c | 17 +++-- 1