Re: [PATCH 1/3] dmaengine: pl330: Do not dereference pl330_thread pointer before non-NULL check

2014-09-08 Thread Krzysztof Kozlowski
On pią, 2014-09-05 at 17:29 +0200, Lars-Peter Clausen wrote: > On 09/05/2014 05:04 PM, Krzysztof Kozlowski wrote: > > Do not dereference the 'struct pl330_thread *thrd' before the check for > > non-NULL value. > > > > This fixes following warning: > > drivers/dma/pl330.c:1376 pl330_submit_req() war

Re: [PATCH 1/3] dmaengine: pl330: Do not dereference pl330_thread pointer before non-NULL check

2014-09-05 Thread Lars-Peter Clausen
On 09/05/2014 05:04 PM, Krzysztof Kozlowski wrote: Do not dereference the 'struct pl330_thread *thrd' before the check for non-NULL value. This fixes following warning: drivers/dma/pl330.c:1376 pl330_submit_req() warn: variable dereferenced before check 'thrd' (see line 1367) I think we can j

[PATCH 1/3] dmaengine: pl330: Do not dereference pl330_thread pointer before non-NULL check

2014-09-05 Thread Krzysztof Kozlowski
Do not dereference the 'struct pl330_thread *thrd' before the check for non-NULL value. This fixes following warning: drivers/dma/pl330.c:1376 pl330_submit_req() warn: variable dereferenced before check 'thrd' (see line 1367) Signed-off-by: Krzysztof Kozlowski --- drivers/dma/pl330.c | 3 ++-