Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-17 Thread Joe Perches
On Wed, 2018-10-17 at 12:29 +0100, Russell King - ARM Linux wrote: > On Tue, Oct 16, 2018 at 04:55:00PM +0300, Andy Shevchenko wrote: > > On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > > > On 16.10.2018 13:29, Andrzej Hajda wrote: > > > > On 16.10.2018 13:01, Andy Shevchenko wrote: > > > >

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 2:29 PM Russell King - ARM Linux wrote: > > On Tue, Oct 16, 2018 at 04:55:00PM +0300, Andy Shevchenko wrote: > > On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > > > On 16.10.2018 13:29, Andrzej Hajda wrote: > > > > On 16.10.2018 13:01, Andy Shevchenko wrote: > > > >

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-17 Thread Russell King - ARM Linux
On Tue, Oct 16, 2018 at 04:55:00PM +0300, Andy Shevchenko wrote: > On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > > On 16.10.2018 13:29, Andrzej Hajda wrote: > > > On 16.10.2018 13:01, Andy Shevchenko wrote: > > >> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda > > >> wrote: > > >>> Duri

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andy Shevchenko
On Tue, Oct 16, 2018 at 3:55 PM Andrzej Hajda wrote: > On 16.10.2018 13:29, Andrzej Hajda wrote: > > On 16.10.2018 13:01, Andy Shevchenko wrote: > >> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: > >>> During probe every time driver gets resource it should usually check for > >>> error >

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
On 16.10.2018 13:29, Andrzej Hajda wrote: > On 16.10.2018 13:01, Andy Shevchenko wrote: >> On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: >>> During probe every time driver gets resource it should usually check for >>> error >>> printk some message if it is not -EPROBE_DEFER and return the

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
On 16.10.2018 13:01, Andy Shevchenko wrote: > On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: >> During probe every time driver gets resource it should usually check for >> error >> printk some message if it is not -EPROBE_DEFER and return the error. This >> pattern is simple but requires a

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Greg Kroah-Hartman
On Tue, Oct 16, 2018 at 11:27:15AM +0100, Mark Brown wrote: > On Tue, Oct 16, 2018 at 09:22:42AM +0200, Andrzej Hajda wrote: > > > +int probe_err(const struct device *dev, int err, const char *fmt, ...) > > +{ > > + struct va_format vaf; > > + va_list args; > > ... > > > + return err; > >

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andy Shevchenko
On Tue, Oct 16, 2018 at 10:22 AM Andrzej Hajda wrote: > > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisition > co

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Mark Brown
On Tue, Oct 16, 2018 at 09:22:42AM +0200, Andrzej Hajda wrote: > +int probe_err(const struct device *dev, int err, const char *fmt, ...) > +{ > + struct va_format vaf; > + va_list args; ... > + return err; > +} > + This will need an EXPORT_SYMBOL for modules won't it? signature.as

Re: [PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Javier Martinez Canillas
Hello Andrzej, On 10/16/2018 09:22 AM, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisition

[PATCH 1/3] driver core: add probe_err log helper

2018-10-16 Thread Andrzej Hajda
During probe every time driver gets resource it should usually check for error printk some message if it is not -EPROBE_DEFER and return the error. This pattern is simple but requires adding few lines after any resource acquisition code, as a result it is often omited or implemented only partially.