Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-13 Thread Maxim Levitsky
On Wed, 2012-08-01 at 14:31 +, Arnd Bergmann wrote: > On Wednesday 01 August 2012, wwang wrote: > > 于 2012年07月31日 19:23, Arnd Bergmann 写道: > > > > > > You posted the sdmmc host driver and the pci card reader driver. > > > I assume that the USB card reader and the memstick host > > > will also

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-13 Thread Maxim Levitsky
On Wed, 2012-08-01 at 14:31 +, Arnd Bergmann wrote: On Wednesday 01 August 2012, wwang wrote: 于 2012年07月31日 19:23, Arnd Bergmann 写道: You posted the sdmmc host driver and the pci card reader driver. I assume that the USB card reader and the memstick host will also get posted at

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-03 Thread Arnd Bergmann
On Friday 03 August 2012, wwang wrote: > I got your ideas. Bus driver depending on other modules is indeed a bad > style. > > In our situation, just take pci device for example, pci-common is the > place to detect card plugged or unplugged, so pci-common is required to > call and probe sdmmc-pci

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-03 Thread Arnd Bergmann
On Friday 03 August 2012, wwang wrote: I got your ideas. Bus driver depending on other modules is indeed a bad style. In our situation, just take pci device for example, pci-common is the place to detect card plugged or unplugged, so pci-common is required to call and probe sdmmc-pci or

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-02 Thread wwang
于 2012年08月01日 22:31, Arnd Bergmann 写道: > > I understand where you are coming from, but IMHO a bus driver would > make more sense if the bus was a low-level abstraction that allows you > to add new high-level drivers (memstick, smartmedia, ...) without > having to modify the low-level drivers,

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-02 Thread wwang
于 2012年08月01日 22:31, Arnd Bergmann 写道: I understand where you are coming from, but IMHO a bus driver would make more sense if the bus was a low-level abstraction that allows you to add new high-level drivers (memstick, smartmedia, ...) without having to modify the low-level drivers, which I

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-01 Thread Arnd Bergmann
On Wednesday 01 August 2012, wwang wrote: > 于 2012年07月31日 19:23, Arnd Bergmann 写道: > > > > You posted the sdmmc host driver and the pci card reader driver. > > I assume that the USB card reader and the memstick host > > will also get posted at some point. Do you have a timeframe > > for those? >

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-01 Thread wwang
于 2012年07月31日 19:23, Arnd Bergmann 写道: > > You posted the sdmmc host driver and the pci card reader driver. > I assume that the USB card reader and the memstick host > will also get posted at some point. Do you have a timeframe > for those? I will submit my memstick host driver around two months

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-01 Thread wwang
于 2012年07月31日 19:23, Arnd Bergmann 写道: You posted the sdmmc host driver and the pci card reader driver. I assume that the USB card reader and the memstick host will also get posted at some point. Do you have a timeframe for those? I will submit my memstick host driver around two months

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-08-01 Thread Arnd Bergmann
On Wednesday 01 August 2012, wwang wrote: 于 2012年07月31日 19:23, Arnd Bergmann 写道: You posted the sdmmc host driver and the pci card reader driver. I assume that the USB card reader and the memstick host will also get posted at some point. Do you have a timeframe for those? I will

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-31 Thread Arnd Bergmann
On Tuesday 31 July 2012, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek card reader core driver is the bus driver for Realtek > driver-based card reader, which supplies adapter layer to > be used by lower-level pci/usb card reader and upper-level > sdmmc/memstick host driver. > >

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-31 Thread wei_wang
From: Wei WANG Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG --- Documentation/misc-devices/realtek_cr.txt |

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-31 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG wei_w...@realsil.com.cn

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-31 Thread Arnd Bergmann
On Tuesday 31 July 2012, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-26 Thread Borislav Petkov
On Thu, Jul 26, 2012 at 09:34:19AM +0800, wwang wrote: > Hi Aaron: > > Thank you. I will modify our host per your suggestion. Hi Wei, please put me on CC for your next submission of the driver so that I can give it a run. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list:

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-26 Thread Borislav Petkov
On Thu, Jul 26, 2012 at 09:34:19AM +0800, wwang wrote: Hi Aaron: Thank you. I will modify our host per your suggestion. Hi Wei, please put me on CC for your next submission of the driver so that I can give it a run. Thanks. -- Regards/Gruss, Boris. -- To unsubscribe from this list:

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread wwang
Hi Aaron: Thank you. I will modify our host per your suggestion. BR, wwang 于 2012年07月25日 18:16, Aaron Lu 写道: Hi Wei, We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would sugget you do something like this: static void realtek_init(struct realtek_sdmmc *host) { struct

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread Aaron Lu
Hi Wei, We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would sugget you do something like this: static void realtek_init(struct realtek_sdmmc *host) { struct mmc_host *mmc = host->mmc; ... ... /* * since you have set MMC_CAP_MAX_CURRENT_800 in your

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread Borislav Petkov
On Wed, Jul 25, 2012 at 10:28:39AM +0800, wwang wrote: > 于 2012年07月24日 22:07, Borislav Petkov 写道: > >Kernel is Linus' from yesterday: v3.5-709-ga6be1fcbc57f and config > >is attached. > > The compilation process is still OK with your config. Yes, but not with the kernel I'm using. If you'd tried

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread wwang
Hi Aaron: Thank you. I will modify our host per your suggestion. BR, wwang 于 2012年07月25日 18:16, Aaron Lu 写道: Hi Wei, We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would sugget you do something like this: static void realtek_init(struct realtek_sdmmc *host) { struct

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread Borislav Petkov
On Wed, Jul 25, 2012 at 10:28:39AM +0800, wwang wrote: 于 2012年07月24日 22:07, Borislav Petkov 写道: Kernel is Linus' from yesterday: v3.5-709-ga6be1fcbc57f and config is attached. The compilation process is still OK with your config. Yes, but not with the kernel I'm using. If you'd tried that

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-25 Thread Aaron Lu
Hi Wei, We do not use MMC_CAP_MAX_CURRENT_* anymore, for your host, I would sugget you do something like this: static void realtek_init(struct realtek_sdmmc *host) { struct mmc_host *mmc = host-mmc; ... ... /* * since you have set MMC_CAP_MAX_CURRENT_800 in your

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread wei_wang
From: Wei WANG Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG --- Documentation/misc-devices/realtek_cr.txt |

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 04:47:34PM +0800, wwang wrote: > This problem doesn't happen in my system. Can you tell me your kernel > version and give me your kernel config? Kernel is Linus' from yesterday: v3.5-709-ga6be1fcbc57f and config is attached. -- Regards/Gruss, Boris. config.gz

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread wwang
于 2012年07月24日 14:44, Borislav Petkov 写道: Ok, thanks for explaining. Btw, the SDMMC part rtsx_sdmmc.c doesn't build here: http://marc.info/?l=linux-kernel=134306261405814=2 Thanks. Hi Borislav: This problem doesn't happen in my system. Can you tell me your kernel version and give me your

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 09:21:34AM +0800, wwang wrote: > Hi Borislav: > > Realtek card reader supports not only SDMMC card, but also Memory > stick. This part is the common code, so it is located in > drivers/misc. There is also SDMMC-relevant code under CONFIG_MMC. > And in the future,

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 09:21:34AM +0800, wwang wrote: Hi Borislav: Realtek card reader supports not only SDMMC card, but also Memory stick. This part is the common code, so it is located in drivers/misc. There is also SDMMC-relevant code under CONFIG_MMC. And in the future,

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread wwang
于 2012年07月24日 14:44, Borislav Petkov 写道: Ok, thanks for explaining. Btw, the SDMMC part rtsx_sdmmc.c doesn't build here: http://marc.info/?l=linux-kernelm=134306261405814w=2 Thanks. Hi Borislav: This problem doesn't happen in my system. Can you tell me your kernel version and give me your

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread Borislav Petkov
On Tue, Jul 24, 2012 at 04:47:34PM +0800, wwang wrote: This problem doesn't happen in my system. Can you tell me your kernel version and give me your kernel config? Kernel is Linus' from yesterday: v3.5-709-ga6be1fcbc57f and config is attached. -- Regards/Gruss, Boris. config.gz

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-24 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG wei_w...@realsil.com.cn

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread wwang
Hi Borislav: Realtek card reader supports not only SDMMC card, but also Memory stick. This part is the common code, so it is located in drivers/misc. There is also SDMMC-relevant code under CONFIG_MMC. And in the future, Memstick-relevant code will be added under CONFIG_MEMSTICK. BR, wwang

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek card reader core driver is the bus driver for Realtek > driver-based card reader, which supplies adapter layer to > be used by lower-level pci/usb card reader and upper-level > sdmmc/memstick

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Matthew Garrett
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: > +SUBSYSTEM=="rtsx_cr", ENV{RTSX_CARD_TYPE}=="SD", RUN+="/sbin/modprobe -bv > rtsx_sdmmc" Ugh. Expose a modalias instead? I know tifm does it like this, but that's probably also an argument for fixing tifm. -- Matthew

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek card reader core driver is the bus driver for Realtek > driver-based card reader, which supplies adapter layer to > be used by lower-level pci/usb card reader and upper-level > sdmmc/memstick

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Dan Carpenter
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: > + > +#define wait_timeout_x(task_state, msecs)\ > +do { \ > + set_current_state((task_state));\ > +

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread wei_wang
From: Wei WANG Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG --- Documentation/misc-devices/realtek_cr.txt |

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG wei_w...@realsil.com.cn

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Dan Carpenter
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: + +#define wait_timeout_x(task_state, msecs)\ +do { \ + set_current_state((task_state));\ +

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Matthew Garrett
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: +SUBSYSTEM==rtsx_cr, ENV{RTSX_CARD_TYPE}==SD, RUN+=/sbin/modprobe -bv rtsx_sdmmc Ugh. Expose a modalias instead? I know tifm does it like this, but that's probably also an argument for fixing tifm. -- Matthew Garrett |

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:38PM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level

Re: [PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-23 Thread wwang
Hi Borislav: Realtek card reader supports not only SDMMC card, but also Memory stick. This part is the common code, so it is located in drivers/misc. There is also SDMMC-relevant code under CONFIG_MMC. And in the future, Memstick-relevant code will be added under CONFIG_MEMSTICK. BR, wwang

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-20 Thread wei_wang
From: Wei WANG Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG --- Documentation/misc-devices/realtek_cr.txt |

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-20 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG wei_w...@realsil.com.cn

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-19 Thread wei_wang
From: Wei WANG Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG --- Documentation/misc-devices/realtek_cr.txt |

[PATCH 1/3] drivers/misc: Add realtek card reader core driver

2012-07-19 Thread wei_wang
From: Wei WANG wei_w...@realsil.com.cn Realtek card reader core driver is the bus driver for Realtek driver-based card reader, which supplies adapter layer to be used by lower-level pci/usb card reader and upper-level sdmmc/memstick host driver. Signed-off-by: Wei WANG wei_w...@realsil.com.cn